linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: "Luis R. Rodriguez" <mcgrof@kernel.org>
Cc: Eric Sandeen <sandeen@sandeen.net>,
	Eric Sandeen <sandeen@redhat.com>, Christoph Hellwig <hch@lst.de>,
	linux-xfs <linux-xfs@vger.kernel.org>,
	gfigueira@suse.com, tetsuya.inoue@suse.com
Subject: Re: [PATCH] xfs: handle error if xfs_btree_get_bufs fails
Date: Tue, 17 Oct 2017 11:35:59 -0700	[thread overview]
Message-ID: <20171017183559.GD4707@magnolia> (raw)
In-Reply-To: <20171017182728.GD17331@wotan.suse.de>

On Tue, Oct 17, 2017 at 08:27:28PM +0200, Luis R. Rodriguez wrote:
> On Fri, Oct 13, 2017 at 02:02:16AM +0200, Luis R. Rodriguez wrote:
> > On Mon, Oct 09, 2017 at 09:07:36PM -0700, Darrick J. Wong wrote:
> > > On Mon, Oct 09, 2017 at 10:07:12PM -0500, Eric Sandeen wrote:
> > > > 
> > > > 
> > > > On 10/9/17 9:19 PM, Luis R. Rodriguez wrote:
> > > > > What ever happened to this patch [0]? It was ACKed [1] 
> > > > 
> > > > (it was reviewed-by hch)
> > > > 
> > > > > but I haven't
> > > > > seen it merged. Did it fall through the cracks?
> > > > 
> > > > Seems like it, possibly because I sent V2 as a re:, accidentally.
> > > 
> > > <grumble>
> > > 
> > > Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> > 
> > If we're going to add this shouldn't we then also have checks for
> > xfs_btree_get_bufl() calls?
> 
> *re-poke*

AFAICT the two callers of xfs_btree_get_bufl already checked that the
incoming argument isn't NULLFSBLOCK, and (at least in theory) the bnobt
shouldn't have freespace records extending outside the filesystem.

That said, new patches accepted. ;)

--D

> 
>   Luis

      reply	other threads:[~2017-10-17 18:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-12 22:00 [PATCH] xfs: handle error if xfs_btree_get_bufs fails Eric Sandeen
2016-12-12 22:14 ` Dave Chinner
2016-12-12 22:33   ` Eric Sandeen
2016-12-12 22:39 ` Eric Sandeen
2016-12-14 10:44   ` Christoph Hellwig
2017-10-10  2:19   ` Luis R. Rodriguez
2017-10-10  3:07     ` Eric Sandeen
2017-10-10  4:07       ` Darrick J. Wong
2017-10-13  0:02         ` Luis R. Rodriguez
2017-10-17 18:27           ` Luis R. Rodriguez
2017-10-17 18:35             ` Darrick J. Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171017183559.GD4707@magnolia \
    --to=darrick.wong@oracle.com \
    --cc=gfigueira@suse.com \
    --cc=hch@lst.de \
    --cc=linux-xfs@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=sandeen@redhat.com \
    --cc=sandeen@sandeen.net \
    --cc=tetsuya.inoue@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).