From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: eguan@redhat.com, linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH 4/5] generic/45[34]: force UTF-8 codeset to enable utf-8 namer checks in xfs_scrub
Date: Thu, 19 Oct 2017 00:18:42 -0700 [thread overview]
Message-ID: <20171019071842.GA28970@infradead.org> (raw)
In-Reply-To: <150836987529.27213.1335818370452284585.stgit@magnolia>
On Wed, Oct 18, 2017 at 04:37:55PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> The upcoming xfs_scrub tool will have the ability to warn about
> suspicious UTF-8 normalization collisions. We want generic/45[34] to be
> able to test this functionality, but to do that we have to forcibly set
> the codeset to UTF-8 via LC_ALL since the rest of xfstests only uses
> LC_ALL=C.
Wait. Where do you want to validate UTF-8 normalization? There is
absolutely no guarantee that someone uses UTF-8, so any reliance on
the character set in the file system is bogus.
next prev parent reply other threads:[~2017-10-19 7:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 23:37 [PATCH 0/5] miscellaneous fstests fixes Darrick J. Wong
2017-10-18 23:37 ` [PATCH 1/5] quota: clear speculative delalloc when checking quota usage Darrick J. Wong
2017-10-18 23:37 ` [PATCH 2/5] common/xfs: refactor xfs_scrub presence testing Darrick J. Wong
2017-10-25 11:04 ` Eryu Guan
2017-10-25 18:54 ` Darrick J. Wong
2017-10-18 23:37 ` [PATCH 3/5] common/xfs: standardize the xfs_scrub output that gets recorded to $seqres.full Darrick J. Wong
2017-10-25 11:06 ` Eryu Guan
2017-10-18 23:37 ` [PATCH 4/5] generic/45[34]: force UTF-8 codeset to enable utf-8 namer checks in xfs_scrub Darrick J. Wong
2017-10-19 7:18 ` Christoph Hellwig [this message]
2017-10-20 17:56 ` Darrick J. Wong
2017-10-18 23:38 ` [PATCH 5/5] xfs: test that we don't leak inodes and dquots during failed cow recovery Darrick J. Wong
2017-10-25 11:48 ` Eryu Guan
2017-10-25 19:09 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171019071842.GA28970@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).