From: Ingo Molnar <mingo@kernel.org>
To: Byungchul Park <byungchul.park@lge.com>
Cc: peterz@infradead.org, axboe@kernel.dk, tglx@linutronix.de,
linux-kernel@vger.kernel.org, linux-mm@kvack.org, tj@kernel.org,
johannes.berg@intel.com, oleg@redhat.com, amir73il@gmail.com,
david@fromorbit.com, darrick.wong@oracle.com,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-block@vger.kernel.org, hch@infradead.org,
idryomov@gmail.com, kernel-team@lge.com
Subject: Re: [PATCH v3 8/8] block: Assign a lock_class per gendisk used for wait_for_completion()
Date: Wed, 25 Oct 2017 07:55:27 +0200 [thread overview]
Message-ID: <20171025055527.jm5scb5vr26g63un@gmail.com> (raw)
In-Reply-To: <20171025002612.GN3310@X58A-UD3R>
* Byungchul Park <byungchul.park@lge.com> wrote:
> > Isn't lockdep_map a zero size structure that is always defined? If yes then
> > there's no need for an #ifdef.
>
> No, a zero size structure for lockdep_map is not provided yet.
> There are two options I can do:
>
> 1. Add a zero size structure for lockdep_map and remove #ifdef
> 2. Replace CONFIG_LOCKDEP_COMPLETIONS with CONFIG_LOCKDEP here.
>
> Or something else?
>
> Which one do you prefer?
Ok, could we try #1 in a new patch and re-spin the simplified block layer patch on
top of that?
The less ugly a debug facility's impact on unrelated kernel is, the better -
especially when it comes to annotating false positives.
Thanks,
Ingo
prev parent reply other threads:[~2017-10-25 5:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-24 9:38 [PATCH v3 0/8] cross-release: enhence performance and fix false positives Byungchul Park
2017-10-24 9:38 ` [PATCH v3 1/8] block: use DECLARE_COMPLETION_ONSTACK in submit_bio_wait Byungchul Park
2017-10-24 9:38 ` [PATCH v3 2/8] lockdep: Introduce CROSSRELEASE_STACK_TRACE and make it not unwind as default Byungchul Park
2017-10-24 10:05 ` Ingo Molnar
2017-10-25 1:01 ` Byungchul Park
2017-10-25 5:53 ` Ingo Molnar
2017-10-24 10:06 ` Ingo Molnar
2017-10-24 9:38 ` [PATCH v3 3/8] lockdep: Remove BROKEN flag of LOCKDEP_CROSSRELEASE Byungchul Park
2017-10-24 10:06 ` Ingo Molnar
2017-10-24 9:38 ` [PATCH v3 4/8] lockdep: Add a kernel parameter, crossrelease_fullstack Byungchul Park
2017-10-24 10:08 ` Ingo Molnar
2017-10-24 23:45 ` Byungchul Park
2017-10-24 9:38 ` [PATCH v3 5/8] completion: Add support for initializing completion with lockdep_map Byungchul Park
2017-10-24 9:38 ` [PATCH v3 6/8] lockdep: Remove unnecessary acquisitions wrt workqueue flush Byungchul Park
2017-10-24 9:38 ` [PATCH v3 7/8] genhd.h: Remove trailing white space Byungchul Park
2017-10-24 10:10 ` Ingo Molnar
2017-10-24 9:38 ` [PATCH v3 8/8] block: Assign a lock_class per gendisk used for wait_for_completion() Byungchul Park
2017-10-24 10:15 ` Ingo Molnar
2017-10-25 0:26 ` Byungchul Park
2017-10-25 5:55 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171025055527.jm5scb5vr26g63un@gmail.com \
--to=mingo@kernel.org \
--cc=amir73il@gmail.com \
--cc=axboe@kernel.dk \
--cc=byungchul.park@lge.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=idryomov@gmail.com \
--cc=johannes.berg@intel.com \
--cc=kernel-team@lge.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).