linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: sandeen@sandeen.net
Cc: linux-xfs@vger.kernel.org, "Luis R. Rodriguez" <mcgrof@kernel.org>
Subject: [PATCH] build: define _DEFAULT_SOURCE if _BSD_SOURCE
Date: Thu, 26 Oct 2017 10:28:57 -0700	[thread overview]
Message-ID: <20171026172857.8683-1-mcgrof@kernel.org> (raw)

./configure will leave traces of a complaint on config.log when
_BSD_SOURCE is defined but not _DEFAULT_SOURCE. _BSD_SOURCE is
deprecated so if defining _BSD_SOURCE also define _DEFAULT_SOURCE.

>From config.log:
/usr/include/features.h:183:3: warning: #warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" [-Wcpp]

Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
---
 m4/package_libcdev.m4 | 1 +
 1 file changed, 1 insertion(+)

diff --git a/m4/package_libcdev.m4 b/m4/package_libcdev.m4
index fa5b63978797..af2a9631b8ba 100644
--- a/m4/package_libcdev.m4
+++ b/m4/package_libcdev.m4
@@ -137,6 +137,7 @@ AC_DEFUN([AC_HAVE_PREADV],
   [ AC_MSG_CHECKING([for preadv])
     AC_TRY_LINK([
 #define _BSD_SOURCE
+#define _DEFAULT_SOURCE
 #include <sys/uio.h>
     ], [
          preadv(0, 0, 0, 0);
-- 
2.14.2


             reply	other threads:[~2017-10-26 17:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-26 17:28 Luis R. Rodriguez [this message]
2017-11-02 20:04 ` [PATCH] build: define _DEFAULT_SOURCE if _BSD_SOURCE Eric Sandeen
2017-11-02 20:22   ` Luis R. Rodriguez
2017-11-02 22:51     ` Eric Sandeen
2017-11-02 22:59       ` Luis R. Rodriguez
2017-11-03  3:10         ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171026172857.8683-1-mcgrof@kernel.org \
    --to=mcgrof@kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=sandeen@sandeen.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).