Re: [PATCH] xfs: fix unused variable warning in xfs_buf_set_ref()

["Darrick J. Wong" <darrick.wong@oracle.com>]

On Fri, Oct 27, 2017 at 06:22:48AM -0400, Brian Foster wrote:
> Fix an unused variable warning on non-DEBUG builds introduced by
> commit 7561d27e90 ("xfs: buffer lru reference count error injection
> tag").
> 
> Signed-off-by: Brian Foster <bfoster@redhat.com>

Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

> ---
> 
> Sigh, sorry for the noise..
> 
> Brian
> 
>  fs/xfs/xfs_buf.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c
> index d481dd2..db786bc 100644
> --- a/fs/xfs/xfs_buf.c
> +++ b/fs/xfs/xfs_buf.c
> @@ -2133,14 +2133,13 @@ xfs_buf_terminate(void)
>  
>  void xfs_buf_set_ref(struct xfs_buf *bp, int lru_ref)
>  {
> -	struct xfs_mount	*mp = bp->b_target->bt_mount;
> -
>  	/*
>  	 * Set the lru reference count to 0 based on the error injection tag.
>  	 * This allows userspace to disrupt buffer caching for debug/testing
>  	 * purposes.
>  	 */
> -	if (XFS_TEST_ERROR(false, mp, XFS_ERRTAG_BUF_LRU_REF))
> +	if (XFS_TEST_ERROR(false, bp->b_target->bt_mount,
> +			   XFS_ERRTAG_BUF_LRU_REF))
>  		lru_ref = 0;
>  
>  	atomic_set(&bp->b_lru_ref, lru_ref);
> -- 
> 2.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html