From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eryu Guan <eguan@redhat.com>
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH 9/6] generic/459: fix test running errors
Date: Fri, 27 Oct 2017 11:22:05 -0700 [thread overview]
Message-ID: <20171027182205.GQ5483@magnolia> (raw)
In-Reply-To: <20171027044201.GU3235@eguan.usersys.redhat.com>
On Fri, Oct 27, 2017 at 12:42:01PM +0800, Eryu Guan wrote:
> On Thu, Oct 26, 2017 at 05:44:46PM -0700, Darrick J. Wong wrote:
> > If the DISCARD of the thin device somehow fails with this message:
> >
> > device-mapper: thin: Data device (dm-1) discard unsupported: Disabling discard passdown.
> >
> > Then we can end up with arbitrary gunk in the thin device. This causes
> > mkfs to fail because it's afraid to format the device. Don't be afraid,
> > just zap it. FWIW mkfs.xfs thinks that the thinp device has an xfs
> > external log because sometimes the thinp device just happen to be backed
> > by the log of the previous test's scratch fs.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> > ---
> > tests/generic/459 | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/generic/459 b/tests/generic/459
> > index 7c10c2a..3dd3681 100755
> > --- a/tests/generic/459
> > +++ b/tests/generic/459
> > @@ -92,7 +92,7 @@ $LVM_PROG lvcreate --virtualsize $virtsize \
> > -T $vgname/$poolname \
> > -n $lvname >>$seqres.full 2>&1
> >
> > -_mkfs_dev /dev/mapper/$vgname-$lvname >>$seqres.full 2>&1
> > +_mkfs_dev -f /dev/mapper/$vgname-$lvname >>$seqres.full 2>&1
>
> I think we should fix it in _mkfs_dev, add a new switch entry for xfs.
Will do.
--D
> Thanks,
> Eryu
>
> >
> >
> > # Running the test over the original volume doesn't reproduce the problem
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-10-27 18:22 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 5:51 [PATCH 1/6] quota: clear speculative delalloc when checking quota usage Darrick J. Wong
2017-10-26 5:51 ` [PATCH 2/6] common/xfs: refactor xfs_scrub presence testing Darrick J. Wong
2017-10-27 4:37 ` Eryu Guan
2017-10-27 18:04 ` Darrick J. Wong
2017-10-27 20:21 ` [PATCH v2 " Darrick J. Wong
2017-10-26 5:51 ` [PATCH 3/6] common/xfs: standardize the xfs_scrub output that gets recorded to $seqres.full Darrick J. Wong
2017-10-26 5:51 ` [PATCH 4/6] generic/45[34]: force UTF-8 codeset to enable utf-8 namer checks in xfs_scrub Darrick J. Wong
2017-10-26 5:52 ` [PATCH 5/6] misc: add module reloading helpers Darrick J. Wong
2017-10-26 6:43 ` Eryu Guan
2017-10-27 0:35 ` Darrick J. Wong
2017-10-27 0:38 ` [PATCH v2 " Darrick J. Wong
2017-10-27 4:41 ` Eryu Guan
2017-10-27 18:18 ` Darrick J. Wong
2017-10-28 5:47 ` Eryu Guan
2017-10-27 20:23 ` [PATCH v3 " Darrick J. Wong
2017-10-26 5:52 ` [PATCH 6/6] xfs: test that we don't leak inodes and dquots during failed cow recovery Darrick J. Wong
2017-10-27 0:42 ` [PATCH v2 " Darrick J. Wong
2017-10-27 0:43 ` [PATCH 7/6] common/fuzzy: online re-scrub should not preen Darrick J. Wong
2017-10-27 0:44 ` [PATCH 8/6] xfs/333: fix errors with new inode pointer verifiers Darrick J. Wong
2017-10-27 6:04 ` Eryu Guan
2017-10-27 18:21 ` Darrick J. Wong
2017-10-27 20:24 ` [PATCH v2 " Darrick J. Wong
2017-11-01 21:13 ` Darrick J. Wong
2017-10-27 0:44 ` [PATCH 9/6] generic/459: fix test running errors Darrick J. Wong
2017-10-27 4:42 ` Eryu Guan
2017-10-27 18:22 ` Darrick J. Wong [this message]
2017-10-27 20:25 ` [PATCH v2 " Darrick J. Wong
2017-10-28 17:07 ` Darrick J. Wong
2017-10-28 17:08 ` [PATCH v3 " Darrick J. Wong
2017-10-30 5:01 ` Eryu Guan
2017-10-27 20:25 ` [PATCH 10/6] common/xfs: remove inode-paths cruft Darrick J. Wong
2017-10-30 5:00 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171027182205.GQ5483@magnolia \
--to=darrick.wong@oracle.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).