From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: eguan@redhat.com
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: [PATCH v2 8/6] xfs/333: fix errors with new inode pointer verifiers
Date: Fri, 27 Oct 2017 13:24:07 -0700 [thread overview]
Message-ID: <20171027202407.GJ5486@magnolia> (raw)
In-Reply-To: <20171027004401.GF5486@magnolia>
Fix test failures with new inode pointer verifiers... and also make sure
that the running xfs actually supports realtime rmap.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
v2: remove the rest of the test after the mount failure
---
tests/xfs/333 | 18 ++++--------------
tests/xfs/333.out | 7 ++-----
2 files changed, 6 insertions(+), 19 deletions(-)
diff --git a/tests/xfs/333 b/tests/xfs/333
index f7f233d..bf0c811 100755
--- a/tests/xfs/333
+++ b/tests/xfs/333
@@ -51,6 +51,8 @@ unset SCRATCH_RTDEV
echo "Format and mount"
_scratch_mkfs > "$seqres.full" 2>&1
+rrmapino="$(_scratch_xfs_db -c 'sb 0' -c 'p rrmapino' 2>&1)"
+test "${rrmapino}" = "field rrmapino not found" && _notrun "realtime rmapbt not supported"
_scratch_mount
echo "Create some files"
@@ -62,21 +64,9 @@ _scratch_unmount
echo "Corrupt fs"
_scratch_xfs_db -x -c 'sb 0' -c "write rrmapino $ino" >> $seqres.full
-_scratch_mount
-
-echo "Check files"
-md5sum $SCRATCH_MNT/f1 2>&1 | _filter_scratch
-
-echo "Try to create more files"
-$XFS_IO_PROG -f -c "pwrite -S 0x68 0 9999" $SCRATCH_MNT/f3 >> $seqres.full 2>&1
+_scratch_mount 2>&1 | _filter_scratch
-echo "Repair fs"
-_scratch_unmount 2>&1 | _filter_scratch
-_repair_scratch_fs >> $seqres.full 2>&1
-
-echo "Try to create more files (again)"
-_scratch_mount
-$XFS_IO_PROG -f -c "pwrite -S 0x68 0 9999" $SCRATCH_MNT/f4 >> $seqres.full
+echo "Test done, mount should have failed"
# success, all done
status=0
diff --git a/tests/xfs/333.out b/tests/xfs/333.out
index bee9bbc..f7518f4 100644
--- a/tests/xfs/333.out
+++ b/tests/xfs/333.out
@@ -2,8 +2,5 @@ QA output created by 333
Format and mount
Create some files
Corrupt fs
-Check files
-8f27047948255cb84872e2dd7c0bc56d SCRATCH_MNT/f1
-Try to create more files
-Repair fs
-Try to create more files (again)
+mount: mount SCRATCH_DEV on SCRATCH_MNT failed: Structure needs cleaning
+Test done, mount should have failed
next prev parent reply other threads:[~2017-10-27 20:24 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 5:51 [PATCH 1/6] quota: clear speculative delalloc when checking quota usage Darrick J. Wong
2017-10-26 5:51 ` [PATCH 2/6] common/xfs: refactor xfs_scrub presence testing Darrick J. Wong
2017-10-27 4:37 ` Eryu Guan
2017-10-27 18:04 ` Darrick J. Wong
2017-10-27 20:21 ` [PATCH v2 " Darrick J. Wong
2017-10-26 5:51 ` [PATCH 3/6] common/xfs: standardize the xfs_scrub output that gets recorded to $seqres.full Darrick J. Wong
2017-10-26 5:51 ` [PATCH 4/6] generic/45[34]: force UTF-8 codeset to enable utf-8 namer checks in xfs_scrub Darrick J. Wong
2017-10-26 5:52 ` [PATCH 5/6] misc: add module reloading helpers Darrick J. Wong
2017-10-26 6:43 ` Eryu Guan
2017-10-27 0:35 ` Darrick J. Wong
2017-10-27 0:38 ` [PATCH v2 " Darrick J. Wong
2017-10-27 4:41 ` Eryu Guan
2017-10-27 18:18 ` Darrick J. Wong
2017-10-28 5:47 ` Eryu Guan
2017-10-27 20:23 ` [PATCH v3 " Darrick J. Wong
2017-10-26 5:52 ` [PATCH 6/6] xfs: test that we don't leak inodes and dquots during failed cow recovery Darrick J. Wong
2017-10-27 0:42 ` [PATCH v2 " Darrick J. Wong
2017-10-27 0:43 ` [PATCH 7/6] common/fuzzy: online re-scrub should not preen Darrick J. Wong
2017-10-27 0:44 ` [PATCH 8/6] xfs/333: fix errors with new inode pointer verifiers Darrick J. Wong
2017-10-27 6:04 ` Eryu Guan
2017-10-27 18:21 ` Darrick J. Wong
2017-10-27 20:24 ` Darrick J. Wong [this message]
2017-11-01 21:13 ` [PATCH v2 " Darrick J. Wong
2017-10-27 0:44 ` [PATCH 9/6] generic/459: fix test running errors Darrick J. Wong
2017-10-27 4:42 ` Eryu Guan
2017-10-27 18:22 ` Darrick J. Wong
2017-10-27 20:25 ` [PATCH v2 " Darrick J. Wong
2017-10-28 17:07 ` Darrick J. Wong
2017-10-28 17:08 ` [PATCH v3 " Darrick J. Wong
2017-10-30 5:01 ` Eryu Guan
2017-10-27 20:25 ` [PATCH 10/6] common/xfs: remove inode-paths cruft Darrick J. Wong
2017-10-30 5:00 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171027202407.GJ5486@magnolia \
--to=darrick.wong@oracle.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).