From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ipmail06.adl6.internode.on.net ([150.101.137.145]:19389 "EHLO ipmail06.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932449AbdJaXXN (ORCPT ); Tue, 31 Oct 2017 19:23:13 -0400 Date: Wed, 1 Nov 2017 10:22:33 +1100 From: Dave Chinner Subject: Re: [PATCH] xfs: move error injection tags into their own file Message-ID: <20171031232233.GI5858@dastard> References: <20171031193128.GG4911@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171031193128.GG4911@magnolia> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: "Darrick J. Wong" Cc: xfs , Eric Sandeen On Tue, Oct 31, 2017 at 12:31:28PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > Move the error injection tag names into a libxfs header so that we can > share it between kernel and userspace. > > Signed-off-by: Darrick J. Wong Simple enough, but there's an admin problem with this patch. > new file mode 100644 > index 0000000..0cc1c05 > --- /dev/null > +++ b/fs/xfs/libxfs/xfs_errortag.h > @@ -0,0 +1,106 @@ > +/* > + * Copyright (C) 2017 Oracle. All Rights Reserved. > + * > + * Author: Darrick J. Wong This isn't actually true. You're moving a bunch of code from fs/xfs/xfs_error.h that is under: * Copyright (c) 2000-2002,2005 Silicon Graphics, Inc. * All Rights Reserved. Moving code into a new file does not reassign the copyright on the code to a new owner. Hence I think this is the appropriate way to record the copyrights on this new file: * Copyright (c) 2000-2002,2005 Silicon Graphics, Inc. * Copyright (C) 2017 Oracle. * All Rights Reserved. And there's no real need for author tags as we've got that information in the git repo.... Cheers, Dave. -- Dave Chinner david@fromorbit.com