From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: xfs <linux-xfs@vger.kernel.org>
Subject: Re: [RFC PATCH] xfs: account for per-AG reservation in statfs f_blocks
Date: Thu, 2 Nov 2017 08:42:50 +1100 [thread overview]
Message-ID: <20171101214250.GS5858@dastard> (raw)
In-Reply-To: <20171101211642.GK4911@magnolia>
On Wed, Nov 01, 2017 at 02:16:42PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Since the blocks reserved by the per-AG reservation mechanism are never
> available to userspace, there's no point in reporting them via statfs.
> Reduce the number of blocks reported by statfs so our space accounting
> works the way it did in the old days -- f_blocks is the theoretical
> upper bound on the amount of space that user programs could allocate,
> and f_blocks is the current maximum.
>
> This eliminates the regression where you format a 100T XFS and df
> reports 2T are already "used". Now it reports that you have a 98T
> filesystem.
>
> (Dave's thinp rfc might very well fix this whole problem; this is
> purely a bandaid to shut down the complaints.)
Yes, it does. These two patches from the series can stand alone,
though I've renamed the variables I used as a result of discussion
with Brian and Amir. If you want to take these instead, I'll post my
updated patches for you:
https://www.spinics.net/lists/linux-xfs/msg12211.html
https://www.spinics.net/lists/linux-xfs/msg12215.html
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2017-11-01 21:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-01 21:16 [RFC PATCH] xfs: account for per-AG reservation in statfs f_blocks Darrick J. Wong
2017-11-01 21:42 ` Dave Chinner [this message]
2017-11-01 22:50 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171101214250.GS5858@dastard \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).