From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:60196 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751428AbdKBDQY (ORCPT ); Wed, 1 Nov 2017 23:16:24 -0400 Date: Thu, 2 Nov 2017 11:16:22 +0800 From: Eryu Guan Subject: Re: [PATCH v2 1/4] common: Check for fiemap range argument support Message-ID: <20171102031622.GV17339@eguan.usersys.redhat.com> References: <1509459011-7398-1-git-send-email-nborisov@suse.com> <1509459096-7585-1-git-send-email-nborisov@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1509459096-7585-1-git-send-email-nborisov@suse.com> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Nikolay Borisov Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org, darrick.wong@oracle.com On Tue, Oct 31, 2017 at 04:11:33PM +0200, Nikolay Borisov wrote: > Signed-off-by: Nikolay Borisov > --- > common/rc | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/common/rc b/common/rc > index e2a8229..673f9ef 100644 > --- a/common/rc > +++ b/common/rc > @@ -2053,8 +2053,15 @@ _require_xfs_io_command() > -c "$command 4k 8k" $testfile 2>&1` > ;; > "fiemap") > + if [ ! -z "$param" ] > + then > + $XFS_IO_PROG -c "help fiemap" | head -n 1 | grep -q "[offset [len]]" || \ ^^^^^^^^^^^^^^^^ this doesn't look correct to me, the "bracket expression" is a "Character Classes", grep matches any single char in the char set. A quick test shows it only matches the last two chars, that's "n]" $ echo "[offset len]" | grep "[offset [len]]" [offset len] ^^ highlighted fgrep should work, or grep -q "\[offset \[len\]\]" But now the fiemap check in _require_xfs_io_command checks range support on whatever $param it takes, even the '[-al] [-n nx]' param that have nothing to do with range. Thanks, Eryu > + _notrun "xfs_io $command range param support is missing" > + fi > + > testio=`$XFS_IO_PROG -F -f -c "pwrite 0 20k" -c "fsync" \ > -c "fiemap -v $param" $testfile 2>&1` > + > param_checked=1 > ;; > "flink" ) > -- > 2.7.4 >