From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from aserp1040.oracle.com ([141.146.126.69]:32827 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933120AbdKBQti (ORCPT ); Thu, 2 Nov 2017 12:49:38 -0400 Date: Thu, 2 Nov 2017 09:49:33 -0700 From: "Darrick J. Wong" Subject: Re: [PATCH 07/14] generic/459: explicitly require thin_check Message-ID: <20171102164933.GW4911@magnolia> References: <150957278824.18388.17975162441125293654.stgit@magnolia> <150957283171.18388.10837345130257598513.stgit@magnolia> <20171102122514.GX17339@eguan.usersys.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171102122514.GX17339@eguan.usersys.redhat.com> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Eryu Guan Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org On Thu, Nov 02, 2017 at 08:25:14PM +0800, Eryu Guan wrote: > On Wed, Nov 01, 2017 at 02:47:11PM -0700, Darrick J. Wong wrote: > > From: Darrick J. Wong > > > > The lvm command can invoke the thin pool utilities as part of managing > > a thin volume. It'll fail if the thin provisioning utilities are not > > installed, so we need to check for its presence before running a test. > > > > Signed-off-by: Darrick J. Wong > > --- > > common/config | 1 + > > tests/generic/459 | 1 + > > 2 files changed, 2 insertions(+) > > > > > > diff --git a/common/config b/common/config > > index 96503c6..eea8669 100644 > > --- a/common/config > > +++ b/common/config > > @@ -196,6 +196,7 @@ export MAN_PROG="`set_prog_path man`" > > export NFS4_SETFACL_PROG="`set_prog_path nfs4_setfacl`" > > export NFS4_GETFACL_PROG="`set_prog_path nfs4_getfacl`" > > export UBIUPDATEVOL_PROG="`set_prog_path ubiupdatevol`" > > +THIN_CHECK_PROG="$(set_prog_path thin_check)" > > I added an 'export' here. Oops, thanks for catching this. --D > > Thanks, > Eryu > > > > > # use 'udevadm settle' or 'udevsettle' to wait for lv to be settled. > > # newer systems have udevadm command but older systems like RHEL5 don't. > > diff --git a/tests/generic/459 b/tests/generic/459 > > index 7c10c2a..d1ad372 100755 > > --- a/tests/generic/459 > > +++ b/tests/generic/459 > > @@ -63,6 +63,7 @@ _supported_os Linux > > _require_scratch_nocheck > > _require_dm_target thin-pool > > _require_command $LVM_PROG lvm > > +_require_command "$THIN_CHECK_PROG" thin_check > > _require_freeze > > > > # remove previous $seqres.full before test > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html