From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:42982 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750707AbdKCPSV (ORCPT ); Fri, 3 Nov 2017 11:18:21 -0400 Date: Fri, 3 Nov 2017 11:18:19 -0400 From: Brian Foster Subject: Re: [PATCH 02/21] xfs: remove a duplicate assignment in xfs_bmap_add_extent_delay_real Message-ID: <20171103151819.GA20279@bfoster.bfoster> References: <20171103144539.2187-1-hch@lst.de> <20171103144539.2187-3-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171103144539.2187-3-hch@lst.de> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Christoph Hellwig Cc: linux-xfs@vger.kernel.org On Fri, Nov 03, 2017 at 05:45:20PM +0300, Christoph Hellwig wrote: > Reported-by: Brian Foster > Signed-off-by: Christoph Hellwig > --- Reviewed-by: Brian Foster > fs/xfs/libxfs/xfs_bmap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c > index db369653eb50..e1d61face277 100644 > --- a/fs/xfs/libxfs/xfs_bmap.c > +++ b/fs/xfs/libxfs/xfs_bmap.c > @@ -1765,7 +1765,7 @@ xfs_bmap_add_extent_delay_real( > LEFT.br_blockcount += new->br_blockcount; > xfs_iext_update_extent(bma->ip, state, bma->idx - 1, &LEFT); > > - PREV.br_blockcount = temp = PREV.br_blockcount - new->br_blockcount; > + PREV.br_blockcount = temp; > PREV.br_startoff += new->br_blockcount; > PREV.br_startblock = nullstartblock(da_new); > xfs_iext_update_extent(bma->ip, state, bma->idx, &PREV); > -- > 2.14.2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html