From: Christoph Hellwig <hch@lst.de>
To: linux-xfs@vger.kernel.org
Subject: [PATCH 5/8] xfs: remove unreachable error injection code in xfs_qm_dqget
Date: Mon, 6 Nov 2017 15:34:53 +0100 [thread overview]
Message-ID: <20171106143456.13567-6-hch@lst.de> (raw)
In-Reply-To: <20171106143456.13567-1-hch@lst.de>
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
fs/xfs/xfs_dquot.c | 17 -----------------
1 file changed, 17 deletions(-)
diff --git a/fs/xfs/xfs_dquot.c b/fs/xfs/xfs_dquot.c
index 8338b894d54f..d57c2db64e59 100644
--- a/fs/xfs/xfs_dquot.c
+++ b/fs/xfs/xfs_dquot.c
@@ -53,13 +53,6 @@
* otherwise by the lowest id first, see xfs_dqlock2.
*/
-#ifdef DEBUG
-xfs_buftarg_t *xfs_dqerror_target;
-int xfs_do_dqerror;
-int xfs_dqreq_num;
-int xfs_dqerror_mod = 33;
-#endif
-
struct kmem_zone *xfs_qm_dqtrxzone;
static struct kmem_zone *xfs_qm_dqzone;
@@ -770,15 +763,6 @@ xfs_qm_dqget(
return -ESRCH;
}
-#ifdef DEBUG
- if (xfs_do_dqerror) {
- if ((xfs_dqerror_target == mp->m_ddev_targp) &&
- (xfs_dqreq_num++ % xfs_dqerror_mod) == 0) {
- xfs_debug(mp, "Returning error in dqget");
- return -EIO;
- }
- }
-
ASSERT(type == XFS_DQ_USER ||
type == XFS_DQ_PROJ ||
type == XFS_DQ_GROUP);
@@ -786,7 +770,6 @@ xfs_qm_dqget(
ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL));
ASSERT(xfs_inode_dquot(ip, type) == NULL);
}
-#endif
restart:
mutex_lock(&qi->qi_tree_lock);
--
2.14.2
next prev parent reply other threads:[~2017-11-06 14:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 14:34 sparse fixes Christoph Hellwig
2017-11-06 14:34 ` [PATCH 1/8] xfs: always define STATIC to static noinline Christoph Hellwig
2017-11-06 20:15 ` Darrick J. Wong
2017-11-06 14:34 ` [PATCH 2/8] xfs: trivial sparse fixes for the new scrub code Christoph Hellwig
2017-11-06 20:10 ` Darrick J. Wong
2017-11-06 14:34 ` [PATCH 3/8] xfs: mark xfs_errortag_ktype static Christoph Hellwig
2017-11-06 20:15 ` Darrick J. Wong
2017-11-06 14:34 ` [PATCH 4/8] xfs: remove unused debug counts for xfs_lock_inodes Christoph Hellwig
2017-11-06 20:17 ` Darrick J. Wong
2017-11-06 14:34 ` Christoph Hellwig [this message]
2017-11-06 20:17 ` [PATCH 5/8] xfs: remove unreachable error injection code in xfs_qm_dqget Darrick J. Wong
2017-11-06 14:34 ` [PATCH 6/8] xfs: mark xfs_btree_check_lblock and xfs_btree_check_ptr static Christoph Hellwig
2017-11-06 20:18 ` Darrick J. Wong
2017-11-06 14:34 ` [PATCH 7/8] xfs: mark xlog_recover_check_summary STATIC Christoph Hellwig
2017-11-06 20:19 ` Darrick J. Wong
2017-11-06 14:34 ` [PATCH 8/8] xfs: mark xlog_verify_dest_ptr STATIC Christoph Hellwig
2017-11-06 20:19 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171106143456.13567-6-hch@lst.de \
--to=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).