From: Eryu Guan <eguan@redhat.com>
To: Hou Tao <houtao1@huawei.com>
Cc: fstests@vger.kernel.org, guaneryu@gmail.com,
linux-xfs@vger.kernel.org, darrick.wong@oracle.com,
cmaiolino@redhat.com
Subject: Re: [PATCH v2 2/4] common/rc: support checking the version of dm-target in _require_dm_target()
Date: Wed, 8 Nov 2017 17:49:14 +0800 [thread overview]
Message-ID: <20171108094914.GP17339@eguan.usersys.redhat.com> (raw)
In-Reply-To: <20171108080250.5662-3-houtao1@huawei.com>
On Wed, Nov 08, 2017 at 04:02:48PM +0800, Hou Tao wrote:
> Some features of dm-target are not available on the old linux kernel,
> and we can use the version of dm-target to check the availability.
We don't check version numbers in fstests, but actually try what is
requested and _notrun if the test run failed.
I think we can keep _require_dm_target unchanged and add a new
_require_dmflakey_error_writes in common/dmflakey, e.g.
_require_dmflakey_error_writes()
{
_require_dm_targets flakey
<try creating flakey table with error_writes option here and
_notrun if failed>
}
And call this new _require rule in the test.
Thanks,
Eryu
next prev parent reply other threads:[~2017-11-08 9:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 8:02 [PATCH v2 0/4] test for XFS umount hang caused by the pending dquota log item in AIL Hou Tao
2017-11-08 8:02 ` [PATCH v2 1/4] dmflakey: support multiple dm targets for a dm-flakey device Hou Tao
2017-11-08 8:02 ` [PATCH v2 2/4] common/rc: support checking the version of dm-target in _require_dm_target() Hou Tao
2017-11-08 9:49 ` Eryu Guan [this message]
2017-11-08 13:39 ` Hou Tao
2017-11-08 8:02 ` [PATCH v2 3/4] xfs: test for umount hang caused by the pending dquota log item in AIL Hou Tao
2017-11-08 9:56 ` Eryu Guan
2017-11-08 13:37 ` Hou Tao
2017-11-08 8:02 ` [PATCH v2 4/4] common/rc: factor out _get|set_xfs_scratch_sb_field() Hou Tao
2017-11-08 16:49 ` Darrick J. Wong
2017-11-09 3:53 ` Eryu Guan
2017-11-09 4:30 ` Hou Tao
2017-11-08 9:20 ` [PATCH v2 0/4] test for XFS umount hang caused by the pending dquota log item in AIL Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171108094914.GP17339@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=cmaiolino@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=houtao1@huawei.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).