* linux-next: build failure after merge of the kspp tree
@ 2017-11-08 5:23 Stephen Rothwell
2017-11-08 23:43 ` Kees Cook
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2017-11-08 5:23 UTC (permalink / raw)
To: Kees Cook, Darrick J. Wong, David Chinner, linux-xfs
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, David Windsor,
Christoph Hellwig
Hi Kees,
After merging the kspp tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:
In file included from include/linux/compiler_types.h:58:0,
from include/uapi/linux/stddef.h:2,
from include/linux/stddef.h:5,
from include/uapi/linux/posix_types.h:5,
from include/uapi/linux/types.h:14,
from include/linux/types.h:6,
from fs/xfs/xfs_linux.h:21,
from fs/xfs/xfs.h:35,
from fs/xfs/xfs_super.c:19:
fs/xfs/xfs_super.c: In function 'xfs_init_zones':
include/linux/compiler-gcc.h:166:2: error: 'xfs_ifork_t {aka struct xfs_ifork}' has no member named 'if_u2'
__builtin_offsetof(a, b)
^
include/linux/stddef.h:17:32: note: in expansion of macro '__compiler_offsetof'
#define offsetof(TYPE, MEMBER) __compiler_offsetof(TYPE, MEMBER)
^
fs/xfs/xfs_super.c:1862:4: note: in expansion of macro 'offsetof'
offsetof(xfs_inode_t, i_df.if_u2.if_inline_data),
^
In file included from include/uapi/linux/posix_types.h:5:0,
from include/uapi/linux/types.h:14,
from include/linux/types.h:6,
from fs/xfs/xfs_linux.h:21,
from fs/xfs/xfs.h:35,
from fs/xfs/xfs_super.c:19:
fs/xfs/xfs_super.c:1863:34: error: 'xfs_ifork_t {aka struct xfs_ifork}' has no member named 'if_u2'
sizeof_field(xfs_inode_t, i_df.if_u2.if_inline_data),
^
include/linux/stddef.h:22:66: note: in definition of macro 'sizeof_field'
#define sizeof_field(structure, field) sizeof((((structure *)0)->field))
^
Caused by commit
1d48144b9688 ("xfs: Define usercopy region in xfs_inode slab cache")
interacting with commit
43518812d297 ("xfs: remove support for inlining data/extents into the inode fork")
from the tree.
I just reverted the kspp tree commit as it seems like it is no longer
needed.
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: linux-next: build failure after merge of the kspp tree
2017-11-08 5:23 linux-next: build failure after merge of the kspp tree Stephen Rothwell
@ 2017-11-08 23:43 ` Kees Cook
2017-11-09 0:18 ` Darrick J. Wong
0 siblings, 1 reply; 4+ messages in thread
From: Kees Cook @ 2017-11-08 23:43 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Darrick J. Wong, David Chinner, linux-xfs,
Linux-Next Mailing List, Linux Kernel Mailing List, David Windsor,
Christoph Hellwig
On Tue, Nov 7, 2017 at 9:23 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Kees,
>
> After merging the kspp tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> In file included from include/linux/compiler_types.h:58:0,
> from include/uapi/linux/stddef.h:2,
> from include/linux/stddef.h:5,
> from include/uapi/linux/posix_types.h:5,
> from include/uapi/linux/types.h:14,
> from include/linux/types.h:6,
> from fs/xfs/xfs_linux.h:21,
> from fs/xfs/xfs.h:35,
> from fs/xfs/xfs_super.c:19:
> fs/xfs/xfs_super.c: In function 'xfs_init_zones':
> include/linux/compiler-gcc.h:166:2: error: 'xfs_ifork_t {aka struct xfs_ifork}' has no member named 'if_u2'
> __builtin_offsetof(a, b)
> ^
> include/linux/stddef.h:17:32: note: in expansion of macro '__compiler_offsetof'
> #define offsetof(TYPE, MEMBER) __compiler_offsetof(TYPE, MEMBER)
> ^
> fs/xfs/xfs_super.c:1862:4: note: in expansion of macro 'offsetof'
> offsetof(xfs_inode_t, i_df.if_u2.if_inline_data),
> ^
> In file included from include/uapi/linux/posix_types.h:5:0,
> from include/uapi/linux/types.h:14,
> from include/linux/types.h:6,
> from fs/xfs/xfs_linux.h:21,
> from fs/xfs/xfs.h:35,
> from fs/xfs/xfs_super.c:19:
> fs/xfs/xfs_super.c:1863:34: error: 'xfs_ifork_t {aka struct xfs_ifork}' has no member named 'if_u2'
> sizeof_field(xfs_inode_t, i_df.if_u2.if_inline_data),
> ^
> include/linux/stddef.h:22:66: note: in definition of macro 'sizeof_field'
> #define sizeof_field(structure, field) sizeof((((structure *)0)->field))
> ^
>
> Caused by commit
>
> 1d48144b9688 ("xfs: Define usercopy region in xfs_inode slab cache")
>
> interacting with commit
>
> 43518812d297 ("xfs: remove support for inlining data/extents into the inode fork")
>
> from the tree.
>
> I just reverted the kspp tree commit as it seems like it is no longer
> needed.
Yup, that looks like the correct fix. Thanks!
-Kees
--
Kees Cook
Pixel Security
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: linux-next: build failure after merge of the kspp tree
2017-11-08 23:43 ` Kees Cook
@ 2017-11-09 0:18 ` Darrick J. Wong
2017-11-09 0:31 ` Kees Cook
0 siblings, 1 reply; 4+ messages in thread
From: Darrick J. Wong @ 2017-11-09 0:18 UTC (permalink / raw)
To: Kees Cook
Cc: Stephen Rothwell, David Chinner, linux-xfs,
Linux-Next Mailing List, Linux Kernel Mailing List, David Windsor,
Christoph Hellwig
On Wed, Nov 08, 2017 at 03:43:47PM -0800, Kees Cook wrote:
> On Tue, Nov 7, 2017 at 9:23 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > Hi Kees,
> >
> > After merging the kspp tree, today's linux-next build (powerpc
> > ppc64_defconfig) failed like this:
> >
> > In file included from include/linux/compiler_types.h:58:0,
> > from include/uapi/linux/stddef.h:2,
> > from include/linux/stddef.h:5,
> > from include/uapi/linux/posix_types.h:5,
> > from include/uapi/linux/types.h:14,
> > from include/linux/types.h:6,
> > from fs/xfs/xfs_linux.h:21,
> > from fs/xfs/xfs.h:35,
> > from fs/xfs/xfs_super.c:19:
> > fs/xfs/xfs_super.c: In function 'xfs_init_zones':
> > include/linux/compiler-gcc.h:166:2: error: 'xfs_ifork_t {aka struct xfs_ifork}' has no member named 'if_u2'
> > __builtin_offsetof(a, b)
> > ^
> > include/linux/stddef.h:17:32: note: in expansion of macro '__compiler_offsetof'
> > #define offsetof(TYPE, MEMBER) __compiler_offsetof(TYPE, MEMBER)
> > ^
> > fs/xfs/xfs_super.c:1862:4: note: in expansion of macro 'offsetof'
> > offsetof(xfs_inode_t, i_df.if_u2.if_inline_data),
> > ^
> > In file included from include/uapi/linux/posix_types.h:5:0,
> > from include/uapi/linux/types.h:14,
> > from include/linux/types.h:6,
> > from fs/xfs/xfs_linux.h:21,
> > from fs/xfs/xfs.h:35,
> > from fs/xfs/xfs_super.c:19:
> > fs/xfs/xfs_super.c:1863:34: error: 'xfs_ifork_t {aka struct xfs_ifork}' has no member named 'if_u2'
> > sizeof_field(xfs_inode_t, i_df.if_u2.if_inline_data),
> > ^
> > include/linux/stddef.h:22:66: note: in definition of macro 'sizeof_field'
> > #define sizeof_field(structure, field) sizeof((((structure *)0)->field))
> > ^
> >
> > Caused by commit
> >
> > 1d48144b9688 ("xfs: Define usercopy region in xfs_inode slab cache")
> >
> > interacting with commit
> >
> > 43518812d297 ("xfs: remove support for inlining data/extents into the inode fork")
> >
> > from the tree.
> >
> > I just reverted the kspp tree commit as it seems like it is no longer
> > needed.
>
> Yup, that looks like the correct fix. Thanks!
Agreed. I guess we'll see you for round X when you get to general
kmalloc annotating. :)
--D
> -Kees
>
> --
> Kees Cook
> Pixel Security
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: linux-next: build failure after merge of the kspp tree
2017-11-09 0:18 ` Darrick J. Wong
@ 2017-11-09 0:31 ` Kees Cook
0 siblings, 0 replies; 4+ messages in thread
From: Kees Cook @ 2017-11-09 0:31 UTC (permalink / raw)
To: Darrick J. Wong
Cc: Stephen Rothwell, David Chinner, linux-xfs,
Linux-Next Mailing List, Linux Kernel Mailing List, David Windsor,
Christoph Hellwig
On Wed, Nov 8, 2017 at 4:18 PM, Darrick J. Wong <darrick.wong@oracle.com> wrote:
> Agreed. I guess we'll see you for round X when you get to general
> kmalloc annotating. :)
That should be "fun". :)
-Kees
--
Kees Cook
Pixel Security
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-09 0:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-08 5:23 linux-next: build failure after merge of the kspp tree Stephen Rothwell
2017-11-08 23:43 ` Kees Cook
2017-11-09 0:18 ` Darrick J. Wong
2017-11-09 0:31 ` Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).