Re: [RFC PATCH] iomap: report collisions between directio and buffered writes to userspace

Holger Hoffstätte
2017-11-15T13:21:38Z

On 11/14/17 22:46, Darrick J. Wong wrote:
(snip)
> +static void iomap_warn_stale_pagecache(struct inode *inode)
> +{
> + errseq_set(&inode->i_mapping->wb_err, -EIO);
> + pr_crit_ratelimited("Stale pagecache contents after collision "
> + "between direct and buffered write!\n");
> +}

In this form the error message is IMHO useless since it tells me
neither the file in question nor the misbehaving application.
"Something went wrong somewhere" is not actionable information
and in practice will only be ignored.

Since you already have the inode in question at hand, print at least
the full path + filename so that it's clear where things are going
wrong. Usually that will let people deduce which application is
misbehaving.

-h