* [PATCH] xfs: fix memory leak in xfs_iext_free_last_leaf
@ 2017-11-20 9:01 shuwang
2017-11-20 9:31 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: shuwang @ 2017-11-20 9:01 UTC (permalink / raw)
To: darrick.wong, hch
Cc: linux-xfs, linux-kernel, bfoster, sandeen, chuhu, liwang, yizhan,
Shu Wang
From: Shu Wang <shuwang@redhat.com>
found the issue by kmemleak.
unreferenced object 0xffff8800674611c0 (size 16):
xfs_iext_insert+0x82a/0xa90 [xfs]
xfs_bmap_add_extent_hole_delay+0x1e5/0x5b0 [xfs]
xfs_bmapi_reserve_delalloc+0x483/0x530 [xfs]
xfs_file_iomap_begin+0xac8/0xd40 [xfs]
iomap_apply+0xb8/0x1b0
iomap_file_buffered_write+0xac/0xe0
xfs_file_buffered_aio_write+0x198/0x420 [xfs]
xfs_file_write_iter+0x23f/0x2a0 [xfs]
__vfs_write+0x23e/0x340
vfs_write+0xe9/0x240
SyS_write+0xa1/0x120
do_syscall_64+0xda/0x260
Signed-off-by: Shu Wang <shuwang@redhat.com>
---
fs/xfs/libxfs/xfs_iext_tree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/xfs/libxfs/xfs_iext_tree.c b/fs/xfs/libxfs/xfs_iext_tree.c
index 19e546a41251..89bf16b4d937 100644
--- a/fs/xfs/libxfs/xfs_iext_tree.c
+++ b/fs/xfs/libxfs/xfs_iext_tree.c
@@ -850,9 +850,9 @@ static void
xfs_iext_free_last_leaf(
struct xfs_ifork *ifp)
{
- ifp->if_u1.if_root = NULL;
ifp->if_height--;
kmem_free(ifp->if_u1.if_root);
+ ifp->if_u1.if_root = NULL;
}
void
--
2.13.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfs: fix memory leak in xfs_iext_free_last_leaf
2017-11-20 9:01 [PATCH] xfs: fix memory leak in xfs_iext_free_last_leaf shuwang
@ 2017-11-20 9:31 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2017-11-20 9:31 UTC (permalink / raw)
To: shuwang
Cc: darrick.wong, hch, linux-xfs, linux-kernel, bfoster, sandeen,
chuhu, liwang, yizhan
Oops. Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-20 9:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-20 9:01 [PATCH] xfs: fix memory leak in xfs_iext_free_last_leaf shuwang
2017-11-20 9:31 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).