From: Christoph Hellwig <hch@infradead.org>
To: Nikolay Borisov <nborisov@suse.com>
Cc: linux-xfs@vger.kernel.org, sandeen@redhat.com, darrick.wong@oracle.com
Subject: Re: [PATCH] xfs: Don't trim extents for fiemap
Date: Thu, 23 Nov 2017 00:15:04 -0800 [thread overview]
Message-ID: <20171123081504.GB24556@infradead.org> (raw)
In-Reply-To: <1511424369-28740-1-git-send-email-nborisov@suse.com>
On Thu, Nov 23, 2017 at 10:06:09AM +0200, Nikolay Borisov wrote:
> For file extents xfs currently always calls xfs_bmapi_read with not flags,
> meaning extents are going to be truncated to the requested range. This is
> differs than what other filesystems do (ext4/btrfs don't trim extents). So
> harmonize the behavior across the filesystem by explicitly not trimming
> extents when we are called from fiemap code.
Given that the iomap code generally trims extents, can you just try
to always enable XFS_BMAPI_ENTIRE?
next prev parent reply other threads:[~2017-11-23 8:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 8:06 [PATCH] xfs: Don't trim extents for fiemap Nikolay Borisov
2017-11-23 8:15 ` Christoph Hellwig [this message]
2017-11-23 8:28 ` Nikolay Borisov
2017-11-23 8:30 ` Christoph Hellwig
2017-11-23 11:35 ` Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171123081504.GB24556@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=nborisov@suse.com \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).