linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Brian Foster <bfoster@redhat.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH 0/4] xfs: inode transaction reservation fixups
Date: Mon, 27 Nov 2017 15:24:30 -0500	[thread overview]
Message-ID: <20171127202434.43125-1-bfoster@redhat.com> (raw)

Hi all,

This series fixes up a few issues related to the xfs_inactive_ifree()
reservation overruns that have been reported on occasion. Patch 1 is a
small fixup to include a bit more data in overrun dumps, patch 2 fixes
an old inode free reservation bug, patch 3 fixes the actual overrun by
implementing an agfl fixup limit and patch 4 is some refactoring of
inode transactions that fell out of discussions on how to address the
problem [1]. 

Patches 1-3 survive an xfstests run and a couple iterations (so far) of
the workload that has consistently reproduced the overrun. I plan to run
the latter test a bit longer and repeat with patch 4 included. Note that
patch 4 is RFC and compile tested only atm.

Thoughts, reviews, flames appreciated.

Brian

[1] https://marc.info/?l=linux-xfs&m=151127676203410&w=2

Brian Foster (4):
  xfs: print transaction log reservation on overrun
  xfs: include inobt buffers in ifree tx log reservation
  xfs: amortize agfl block frees across multiple transactions
  xfs: include an allocfree res for inobt modifications

 fs/xfs/libxfs/xfs_alloc.c      | 15 ++++---
 fs/xfs/libxfs/xfs_trans_resv.c | 93 +++++++++++++++++++++---------------------
 fs/xfs/xfs_log.c               |  4 +-
 3 files changed, 60 insertions(+), 52 deletions(-)

-- 
2.13.6


             reply	other threads:[~2017-11-27 20:24 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-27 20:24 Brian Foster [this message]
2017-11-27 20:24 ` [PATCH 1/4] xfs: print transaction log reservation on overrun Brian Foster
2017-11-27 22:14   ` Dave Chinner
2017-11-27 20:24 ` [PATCH 2/4] xfs: include inobt buffers in ifree tx log reservation Brian Foster
2017-11-27 22:28   ` Dave Chinner
2017-11-28 13:30     ` Brian Foster
2017-11-28 21:38       ` Dave Chinner
2017-11-29 14:31         ` Brian Foster
2017-11-27 20:24 ` [PATCH 3/4] xfs: amortize agfl block frees across multiple transactions Brian Foster
2017-11-27 23:07   ` Dave Chinner
2017-11-28 13:57     ` Brian Foster
2017-11-28 22:09       ` Dave Chinner
2017-11-29 18:24         ` Brian Foster
2017-11-29 20:36           ` Brian Foster
2017-12-05 20:53             ` Brian Foster
2017-11-27 20:24 ` [PATCH RFC 4/4] xfs: include an allocfree res for inobt modifications Brian Foster
2017-11-27 23:27   ` Dave Chinner
2017-11-28 14:04     ` Brian Foster
2017-11-28 22:26       ` Dave Chinner
2017-11-29 14:32         ` Brian Foster
2017-11-28 15:49     ` Brian Foster
2017-11-28 22:34       ` Dave Chinner
2017-11-29 14:32         ` Brian Foster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171127202434.43125-1-bfoster@redhat.com \
    --to=bfoster@redhat.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).