From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eryu Guan <eguan@redhat.com>
Cc: fstests <fstests@vger.kernel.org>, xfs <linux-xfs@vger.kernel.org>
Subject: [PATCH] common/rc: report kmemleak errors
Date: Tue, 28 Nov 2017 17:09:37 -0800 [thread overview]
Message-ID: <20171129010937.GB31372@magnolia> (raw)
From: Darrick J. Wong <darrick.wong@oracle.com>
If kmemleak is enabled, scan and report memory leaks after every test.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
check | 2 ++
common/rc | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 53 insertions(+)
diff --git a/check b/check
index b2d251a..469188e 100755
--- a/check
+++ b/check
@@ -497,6 +497,7 @@ _check_filesystems()
fi
}
+_init_kmemleak
_prepare_test_list
if $OPTIONS_HAVE_SECTIONS; then
@@ -793,6 +794,7 @@ for section in $HOST_OPTIONS_SECTIONS; do
n_try=`expr $n_try + 1`
_check_filesystems
_check_dmesg || err=true
+ _check_kmemleak || err=true
fi
fi
diff --git a/common/rc b/common/rc
index cb83918..6dc77d5 100644
--- a/common/rc
+++ b/common/rc
@@ -3339,6 +3339,57 @@ _check_dmesg()
fi
}
+# set up kmemleak
+_init_kmemleak()
+{
+ local _kern_knob="/sys/kernel/debug/kmemleak"
+
+ if [ ! -w "${_kern_knob}" ]; then
+ return 0
+ fi
+
+ # Scan for all the memory leaks that have happened to date and
+ # clear them so that we can pinpoint leaks to tests accurately.
+ # Scan twice because the first write finishes before the scan
+ # does....
+ echo "scan" > "${_kern_knob}"
+ cat "${_kern_knob}" > /dev/null
+ echo "scan" > "${_kern_knob}"
+ cat "${_kern_knob}" > /dev/null
+ echo "clear" > "${_kern_knob}"
+}
+
+# check kmemleak log
+_check_kmemleak()
+{
+ local _kern_knob="/sys/kernel/debug/kmemleak"
+ local _leak_file="${RESULT_DIR}/check_kmemleak"
+
+ if [ ! -w "${_kern_knob}" ]; then
+ return 0
+ fi
+
+ # Tell the kernel to scan for memory leaks. Apparently the write
+ # returns before the scan is complete, so do it twice in the hopes
+ # that twice is enough to capture all the leaks.
+ echo "scan" > "${_kern_knob}"
+ sed -e 's/age [0-9\.]*s/age XXXX/g' < "${_kern_knob}" > "${_leak_file}.new"
+ echo "scan" > "${_kern_knob}"
+ sed -e 's/age [0-9\.]*s/age XXXX/g' < "${_kern_knob}" > "${_leak_file}.new"
+
+ diff -u -N "${_leak_file}" "${_leak_file}.new" > $seqres.kmemleak
+ res=$?
+ mv "${_leak_file}.new" "${_leak_file}"
+
+ if [ $res -ne 0 ]; then
+ _dump_err "_check_kmemleak: something found in kmemleak (see $seqres.kmemleak)"
+ return 1
+ else
+ rm -f $seqres.kmemleak
+ return 0
+ fi
+}
+
# don't check dmesg log after test
_disable_dmesg_check()
{
next reply other threads:[~2017-11-29 1:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 1:09 Darrick J. Wong [this message]
2017-12-04 4:55 ` [PATCH] common/rc: report kmemleak errors Eryu Guan
2017-12-04 18:45 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171129010937.GB31372@magnolia \
--to=darrick.wong@oracle.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).