linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: xfs <linux-xfs@vger.kernel.org>
Subject: [PATCH] xfsdocs: fix some small discrepancies with libxfs
Date: Tue, 28 Nov 2017 17:48:17 -0800	[thread overview]
Message-ID: <20171129014817.GD21412@magnolia> (raw)

From: Darrick J. Wong <darrick.wong@oracle.com>

Fix some small discrepancies between the current libxfs code and this doc.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 design/XFS_Filesystem_Structure/btrees.asciidoc    |    2 +-
 design/XFS_Filesystem_Structure/dabtrees.asciidoc  |    8 ++++++--
 .../extended_attributes.asciidoc                   |    1 +
 .../internal_inodes.asciidoc                       |    2 +-
 4 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/design/XFS_Filesystem_Structure/btrees.asciidoc b/design/XFS_Filesystem_Structure/btrees.asciidoc
index 91a53c4..19680d0 100644
--- a/design/XFS_Filesystem_Structure/btrees.asciidoc
+++ b/design/XFS_Filesystem_Structure/btrees.asciidoc
@@ -104,7 +104,7 @@ Specifies the magic number for the per-AG B+tree block.
 *bb_level*::
 The level of the tree in which this block is found.  If this value is 0, this
 is a leaf block and contains records; otherwise, it is a node block and
-contains keys and pointers.
+contains keys and pointers.  Level values increase towards the root.
 
 *bb_numrecs*::
 Number of records in this block.
diff --git a/design/XFS_Filesystem_Structure/dabtrees.asciidoc b/design/XFS_Filesystem_Structure/dabtrees.asciidoc
index 18247ca..29cfdab 100644
--- a/design/XFS_Filesystem_Structure/dabtrees.asciidoc
+++ b/design/XFS_Filesystem_Structure/dabtrees.asciidoc
@@ -170,7 +170,9 @@ Directory/attribute block info.  The magic number is +XFS_DA_NODE_MAGIC+
 Number of node entries in this block.
 
 *level*::
-The level of this block in the B+tree.
+The level of this block in the B+tree.  Levels start at 1 for blocks
+that point to directory or attribute data blocks and increase towards
+the root.
 
 *hashval*::
 The hash value of a particular record.
@@ -206,7 +208,9 @@ Directory/attribute block info.  The magic number is +XFS_DA3_NODE_MAGIC+
 Number of node entries in this block.
 
 *level*::
-The level of this block in the B+tree.
+The level of this block in the B+tree.  Levels start at 1 for blocks
+that point to directory or attribute data blocks, and increase towards
+the root.
 
 *pad32*::
 Padding to maintain alignment.
diff --git a/design/XFS_Filesystem_Structure/extended_attributes.asciidoc b/design/XFS_Filesystem_Structure/extended_attributes.asciidoc
index bb773d5..7df2d3d 100644
--- a/design/XFS_Filesystem_Structure/extended_attributes.asciidoc
+++ b/design/XFS_Filesystem_Structure/extended_attributes.asciidoc
@@ -473,6 +473,7 @@ typedef struct xfs_attr3_leaf_hdr {
      __u8                       holes;
      __u8                       pad1;
      xfs_attr_leaf_map_t        freemap[3];
+     __be32                     pad2;
 } xfs_attr3_leaf_hdr_t;
 
 
diff --git a/design/XFS_Filesystem_Structure/internal_inodes.asciidoc b/design/XFS_Filesystem_Structure/internal_inodes.asciidoc
index e6bf75f..f5c2654 100644
--- a/design/XFS_Filesystem_Structure/internal_inodes.asciidoc
+++ b/design/XFS_Filesystem_Structure/internal_inodes.asciidoc
@@ -59,7 +59,7 @@ struct xfs_disk_dquot {
 };
 struct xfs_dqblk {
      struct xfs_disk_dquot dd_diskdq;
-     char                  dd_fill[32];
+     char                  dd_fill[4];
 
      /* version 5 filesystem fields begin here */
      __be32                dd_crc;

                 reply	other threads:[~2017-11-29  1:48 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171129014817.GD21412@magnolia \
    --to=darrick.wong@oracle.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).