linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs_io: add buf_lru_ref tag to inject table
Date: Thu, 30 Nov 2017 14:23:57 -0800	[thread overview]
Message-ID: <20171130222357.GN21412@magnolia> (raw)
In-Reply-To: <79e391ff-fbb5-baf9-bb36-776d956ccecf@redhat.com>

On Thu, Nov 30, 2017 at 04:12:32PM -0600, Eric Sandeen wrote:
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

/me wonders if we could make so that the compiler complains about
missing table entries here, but that's orthogonal to this patch so:

Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
> 
> it might be nice to also allow specification by number, but
> for now just fix this up to match the currently-defined tags.
> 
> diff --git a/io/inject.c b/io/inject.c
> index 9d0cf62..2f15854 100644
> --- a/io/inject.c
> +++ b/io/inject.c
> @@ -62,6 +62,7 @@ error_tag(char *name)
>  		{ XFS_ERRTAG_DROP_WRITES,		"drop_writes" },
>  		{ XFS_ERRTAG_LOG_BAD_CRC,		"log_bad_crc" },
>  		{ XFS_ERRTAG_LOG_ITEM_PIN,		"log_item_pin" },
> +		{ XFS_ERRTAG_BUF_LRU_REF,		"buf_lru_ref" },
>  		{ XFS_ERRTAG_MAX,			NULL }
>  	};
>  	int	count;
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2017-11-30 22:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-30 22:12 [PATCH] xfs_io: add buf_lru_ref tag to inject table Eric Sandeen
2017-11-30 22:23 ` Darrick J. Wong [this message]
2017-11-30 22:57 ` [PATCH V2] " Eric Sandeen
2017-11-30 23:04   ` [PATCH V3] " Eric Sandeen
2017-11-30 23:13     ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171130222357.GN21412@magnolia \
    --to=darrick.wong@oracle.com \
    --cc=linux-xfs@vger.kernel.org \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).