From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Eric Sandeen <sandeen@redhat.com>, linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH 1/4] xfs: add scrub to XFS_BUILD_OPTIONS
Date: Fri, 1 Dec 2017 14:29:22 -0800 [thread overview]
Message-ID: <20171201222922.GZ21412@magnolia> (raw)
In-Reply-To: <f5769e20-970a-53f5-4fc7-2afd11304ce2@sandeen.net>
On Fri, Dec 01, 2017 at 04:12:34PM -0600, Eric Sandeen wrote:
> Advertise this config option along with the others.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> diff --git a/fs/xfs/xfs_super.h b/fs/xfs/xfs_super.h
> index fcc5dfc..8cee8e8 100644
> --- a/fs/xfs/xfs_super.h
> +++ b/fs/xfs/xfs_super.h
> @@ -44,6 +44,12 @@
> # define XFS_REALTIME_STRING
> #endif
>
> +#ifdef CONFIG_XFS_ONLINE_SCRUB
> +# define XFS_SCRUB_STRING "scrub, "
> +#else
> +# define XFS_SCRUB_STRING
> +#endif
I don't mind this addition to the build options, though I had pictured
scrub becoming an integral part of xfs some day and not remaining a
configurable option.
That said I haven't evaluated how much scrub bloats up xfs nor do I know
if the kernel tinyfication people would actually want to turn it off??
(For my part I prefer it some day not be Kconfig option so that it won't
bitrot ala CONFIG_XFS_RT=y.)
--D
> +
> #ifdef DEBUG
> # define XFS_DBG_STRING "debug"
> #else
> @@ -54,6 +60,7 @@
> #define XFS_BUILD_OPTIONS XFS_ACL_STRING \
> XFS_SECURITY_STRING \
> XFS_REALTIME_STRING \
> + XFS_SCRUB_STRING \
> XFS_DBG_STRING /* DBG must be last */
>
> struct xfs_inode;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-12-01 22:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 22:11 [PATCH 0/4] xfs: scrub tweaks Eric Sandeen
2017-12-01 22:12 ` [PATCH 1/4] xfs: add scrub to XFS_BUILD_OPTIONS Eric Sandeen
2017-12-01 22:29 ` Darrick J. Wong [this message]
2017-12-01 22:31 ` Eric Sandeen
2018-02-01 0:03 ` Darrick J. Wong
2017-12-01 22:13 ` [PATCH 2/4] xfs: explicitly initialize meta_scrub_ops array by type Eric Sandeen
2017-12-01 22:26 ` Darrick J. Wong
2017-12-01 22:14 ` [PATCH 3/4] xfs: factor out scrub input checking Eric Sandeen
2017-12-01 22:25 ` Darrick J. Wong
2017-12-01 23:23 ` [PATCH v2 " Darrick J. Wong
2017-12-01 22:15 ` [PATCH 4/4] xfs: move all scrub input checking to xfs_scrub_validate Eric Sandeen
2017-12-01 22:24 ` Darrick J. Wong
2017-12-01 22:25 ` Eric Sandeen
2017-12-01 23:02 ` Darrick J. Wong
2017-12-01 23:24 ` [PATCH v2 " Darrick J. Wong
2017-12-01 22:39 ` [PATCH 0/4] xfs: scrub tweaks Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171201222922.GZ21412@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).