From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: sandeen@redhat.com, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/5 V2] xfs_db: print structure padding fields consistently
Date: Mon, 4 Dec 2017 15:56:13 -0800 [thread overview]
Message-ID: <20171204235613.GB19219@magnolia> (raw)
In-Reply-To: <bb3d13c6-d692-7ac4-852e-00f8523cffef@sandeen.net>
On Mon, Dec 04, 2017 at 05:54:09PM -0600, Eric Sandeen wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> We are very inconsistent about how we print padding fields in on-disk
> structures -- sometimes we hide it from printall, sometimes we deviate
> from unsigned hex values, etc. Make this all consistent -- always hide
> padding values when printing the whole structure, always print them as
> unsigned hex integers when explicitly requested.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> [sandeen: switch to never-print instead of always-print]
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
> ---
>
> V2: constant-ify by never printing instead of always printing,
> but still make format consistent.
>
> diff --git a/db/attr.c b/db/attr.c
> index 75fe239..9cbb20d 100644
> --- a/db/attr.c
> +++ b/db/attr.c
> @@ -589,7 +589,7 @@ const field_t attr3_node_hdr_flds[] = {
> { "info", FLDT_ATTR3_BLKINFO, OI(H3OFF(info)), C1, 0, TYP_NONE },
> { "count", FLDT_UINT16D, OI(H3OFF(__count)), C1, 0, TYP_NONE },
> { "level", FLDT_UINT16D, OI(H3OFF(__level)), C1, 0, TYP_NONE },
> - { "pad", FLDT_UINT32D, OI(H3OFF(__pad32)), C1, 0, TYP_NONE },
> + { "pad", FLDT_UINT32X, OI(H3OFF(__pad32)), C1, FLD_SKIPALL, TYP_NONE },
> { NULL }
> };
>
> diff --git a/db/dir2.c b/db/dir2.c
> index 3e21a7b..7f7ea5a 100644
> --- a/db/dir2.c
> +++ b/db/dir2.c
> @@ -977,7 +977,7 @@ const field_t da3_node_hdr_flds[] = {
> { "info", FLDT_DA3_BLKINFO, OI(H3OFF(info)), C1, 0, TYP_NONE },
> { "count", FLDT_UINT16D, OI(H3OFF(__count)), C1, 0, TYP_NONE },
> { "level", FLDT_UINT16D, OI(H3OFF(__level)), C1, 0, TYP_NONE },
> - { "pad", FLDT_UINT32D, OI(H3OFF(__pad32)), C1, 0, TYP_NONE },
> + { "pad", FLDT_UINT32X, OI(H3OFF(__pad32)), C1, FLD_SKIPALL, TYP_NONE },
> { NULL }
> };
>
> diff --git a/db/dquot.c b/db/dquot.c
> index 4e35df4..4fd1289 100644
> --- a/db/dquot.c
> +++ b/db/dquot.c
> @@ -76,7 +76,7 @@ const field_t disk_dquot_flds[] = {
> { "btimer", FLDT_INT32D, OI(DOFF(btimer)), C1, 0, TYP_NONE },
> { "iwarns", FLDT_QWARNCNT, OI(DOFF(iwarns)), C1, 0, TYP_NONE },
> { "bwarns", FLDT_QWARNCNT, OI(DOFF(bwarns)), C1, 0, TYP_NONE },
> - { "pad0", FLDT_INT32D, OI(DOFF(pad0)), C1, FLD_SKIPALL, TYP_NONE },
> + { "pad0", FLDT_UINT32X, OI(DOFF(pad0)), C1, FLD_SKIPALL, TYP_NONE },
> { "rtb_hardlimit", FLDT_QCNT, OI(DOFF(rtb_hardlimit)), C1, 0,
> TYP_NONE },
> { "rtb_softlimit", FLDT_QCNT, OI(DOFF(rtb_softlimit)), C1, 0,
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-12-04 23:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-17 19:56 [PATCH 0/5] xfsprogs: 4.15 rollup Darrick J. Wong
2017-11-17 19:56 ` [PATCH 1/5] xfs_db: print structure padding fields consistently Darrick J. Wong
2017-11-30 21:37 ` Eric Sandeen
2017-11-30 21:51 ` Darrick J. Wong
2017-11-30 21:57 ` Eric Sandeen
2017-11-30 22:01 ` Darrick J. Wong
2017-12-04 23:54 ` [PATCH 1/5 V2] " Eric Sandeen
2017-12-04 23:56 ` Darrick J. Wong [this message]
2017-11-17 19:56 ` [PATCH 2/5] xfs_db: add missing padding fields Darrick J. Wong
2017-12-04 23:54 ` [PATCH 2/5 V2] " Eric Sandeen
2017-12-04 23:56 ` Darrick J. Wong
2017-11-17 19:56 ` [PATCH 3/5] xfs_io: pull xfs errortag definitions from libxfs Darrick J. Wong
2017-11-30 21:40 ` Eric Sandeen
2017-11-17 19:57 ` [PATCH 4/5] xfs_io: provide an interface to the scrub ioctls Darrick J. Wong
2017-12-01 3:46 ` Eric Sandeen
2017-12-01 17:02 ` Darrick J. Wong
2017-12-01 16:06 ` Eric Sandeen
2017-12-01 17:03 ` Darrick J. Wong
2017-12-01 19:02 ` [PATCH v2 " Darrick J. Wong
2017-12-04 21:19 ` Eric Sandeen
2017-11-17 19:57 ` [PATCH 5/5] man: describe the metadata scrubbing ioctl Darrick J. Wong
2017-12-01 4:34 ` Eric Sandeen
2017-12-01 5:00 ` Eric Sandeen
2017-12-01 18:12 ` Darrick J. Wong
2017-12-01 19:03 ` [PATCH v2 " Darrick J. Wong
2017-12-04 21:19 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171204235613.GB19219@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).