From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Pravin Shedge <pravin.shedge4linux@gmail.com>
Cc: linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 22/45] fs: xfs: remove duplicate includes
Date: Wed, 6 Dec 2017 10:19:22 -0800 [thread overview]
Message-ID: <20171206181922.GL19219@magnolia> (raw)
In-Reply-To: <1512576966-4303-1-git-send-email-pravin.shedge4linux@gmail.com>
On Wed, Dec 06, 2017 at 09:46:06PM +0530, Pravin Shedge wrote:
> These duplicate includes have been found with scripts/checkincludes.pl but
> they have been removed manually to avoid removing false positives.
>
> Signed-off-by: Pravin Shedge <pravin.shedge4linux@gmail.com>
Looks ok, will pick this up.
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> fs/xfs/scrub/scrub.c | 1 -
> fs/xfs/scrub/trace.c | 1 -
> fs/xfs/xfs_reflink.c | 2 --
> fs/xfs/xfs_trace.c | 1 -
> 4 files changed, 5 deletions(-)
>
> diff --git a/fs/xfs/scrub/scrub.c b/fs/xfs/scrub/scrub.c
> index 9c42c4e..ab3aef2 100644
> --- a/fs/xfs/scrub/scrub.c
> +++ b/fs/xfs/scrub/scrub.c
> @@ -46,7 +46,6 @@
> #include "scrub/scrub.h"
> #include "scrub/common.h"
> #include "scrub/trace.h"
> -#include "scrub/scrub.h"
> #include "scrub/btree.h"
>
> /*
> diff --git a/fs/xfs/scrub/trace.c b/fs/xfs/scrub/trace.c
> index 472080e..86daed0 100644
> --- a/fs/xfs/scrub/trace.c
> +++ b/fs/xfs/scrub/trace.c
> @@ -26,7 +26,6 @@
> #include "xfs_mount.h"
> #include "xfs_defer.h"
> #include "xfs_da_format.h"
> -#include "xfs_defer.h"
> #include "xfs_inode.h"
> #include "xfs_btree.h"
> #include "xfs_trans.h"
> diff --git a/fs/xfs/xfs_reflink.c b/fs/xfs/xfs_reflink.c
> index cc041a2..cf7c8f8 100644
> --- a/fs/xfs/xfs_reflink.c
> +++ b/fs/xfs/xfs_reflink.c
> @@ -49,8 +49,6 @@
> #include "xfs_alloc.h"
> #include "xfs_quota_defs.h"
> #include "xfs_quota.h"
> -#include "xfs_btree.h"
> -#include "xfs_bmap_btree.h"
> #include "xfs_reflink.h"
> #include "xfs_iomap.h"
> #include "xfs_rmap_btree.h"
> diff --git a/fs/xfs/xfs_trace.c b/fs/xfs/xfs_trace.c
> index 5d95fe3..35f3546 100644
> --- a/fs/xfs/xfs_trace.c
> +++ b/fs/xfs/xfs_trace.c
> @@ -24,7 +24,6 @@
> #include "xfs_mount.h"
> #include "xfs_defer.h"
> #include "xfs_da_format.h"
> -#include "xfs_defer.h"
> #include "xfs_inode.h"
> #include "xfs_btree.h"
> #include "xfs_da_btree.h"
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-12-06 18:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 16:16 [PATCH 22/45] fs: xfs: remove duplicate includes Pravin Shedge
2017-12-06 18:19 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171206181922.GL19219@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=pravin.shedge4linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox