linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Dave Chinner <david@fromorbit.com>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: remove "no-allocation" reservations for file creations
Date: Wed, 6 Dec 2017 16:19:11 -0800	[thread overview]
Message-ID: <20171207001911.GR19219@magnolia> (raw)
In-Reply-To: <20171207000259.GA18701@lst.de>

On Thu, Dec 07, 2017 at 01:02:59AM +0100, Christoph Hellwig wrote:
> On Tue, Dec 05, 2017 at 10:59:36AM -0800, Darrick J. Wong wrote:
> > I fixed most of the auto group regressions with small fixes to xfstests,
> > but xfs/013 is a problem because once we run out of space to create new
> > dirX we simply get nothing.  Will have to study the behavior of that
> > test in more depth...
> 
> With what kind of config do you see xfs/013 failures?

MKFS_OPTIONS='-m rmapbt=1,reflink=1 -i sparse=1'

I /think/ the fix is that the cp -Rl can sometimes fail to create
dir$((i+1)) because we happen to hit exactly the point where the cleaner
hasn't caught up with fsstress and so the dir$((i+1)) creation
transaction fails with ENOSPC.  AFAICT if I change that to:

while ! test -d $SCRATCH_MNT/dir$((i+1)); do
	cp -Rl ...
done

then xfs/013 exercises the finobt just fine and doesn't fail.

--D

> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2017-12-07  0:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-21  8:24 [PATCH] xfs: remove "no-allocation" reservations for file creations Christoph Hellwig
2017-08-23 20:22 ` Darrick J. Wong
2017-08-24  0:47   ` Dave Chinner
2017-08-24  0:57     ` Darrick J. Wong
2017-08-29 18:04     ` Darrick J. Wong
2017-09-03  7:25       ` Christoph Hellwig
2017-09-03 15:31         ` Darrick J. Wong
2017-12-05  1:34           ` Darrick J. Wong
2017-12-05 18:59             ` Darrick J. Wong
2017-12-07  0:02               ` Christoph Hellwig
2017-12-07  0:19                 ` Darrick J. Wong [this message]
2017-08-24 12:18   ` Christoph Hellwig
2017-12-07  0:15 ` Darrick J. Wong
2017-12-07  0:17   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171207001911.GR19219@magnolia \
    --to=darrick.wong@oracle.com \
    --cc=david@fromorbit.com \
    --cc=hch@lst.de \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).