From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Eric Sandeen <sandeen@sandeen.net>,
linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH 1/5] mkfs: Don't emit default config message yet
Date: Fri, 8 Dec 2017 15:54:22 +1100 [thread overview]
Message-ID: <20171208045422.GL5858@dastard> (raw)
In-Reply-To: <20171208042153.GI19219@magnolia>
On Thu, Dec 07, 2017 at 08:21:53PM -0800, Darrick J. Wong wrote:
> On Thu, Dec 07, 2017 at 10:13:15PM -0600, Eric Sandeen wrote:
> > Until we have more than one possible source of configuration,
> > there is no need to emit the only possibility and clutter
> > the output. We can decide how it should all look when we
> > get more than one source.
> >
> > Apply some i18n to the config description, though.
> >
> > Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>
> Looks ok, I guess,
> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
>
> (I wonder why Dave put the printf in there, but I'll let him answer that.)
Because I wanted to demonstrate to everyone where the config file
based defaults should be introduced. i.e. before the printf that
says where the defaults were sourced from!
-Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2017-12-08 4:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 4:11 [PATCH 0/5] mkfs: minor tidyups Eric Sandeen
2017-12-08 4:13 ` [PATCH 1/5] mkfs: Don't emit default config message yet Eric Sandeen
2017-12-08 4:21 ` Darrick J. Wong
2017-12-08 4:54 ` Dave Chinner [this message]
2017-12-08 13:37 ` Eric Sandeen
2017-12-08 4:13 ` [PATCH 2/5] mkfs: remove unused m_uuid in sb_feat_args Eric Sandeen
2017-12-08 4:22 ` Darrick J. Wong
2017-12-08 4:15 ` [PATCH 3/5] mkfs: invert project id width boolean name Eric Sandeen
2017-12-08 4:18 ` Darrick J. Wong
2017-12-08 4:17 ` [PATCH 4/5] mkfs: document sb_feat_args members Eric Sandeen
2017-12-08 4:27 ` Darrick J. Wong
2017-12-08 4:59 ` Dave Chinner
2017-12-08 4:18 ` [PATCH 5/5] mkfs: remove use-once default macros Eric Sandeen
2017-12-08 4:27 ` Darrick J. Wong
2017-12-08 5:01 ` [PATCH 0/5] mkfs: minor tidyups Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171208045422.GL5858@dastard \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox