Re: [PATCH 4/5] mkfs: document sb_feat_args members

[Dave Chinner <david@fromorbit.com>]

On Thu, Dec 07, 2017 at 08:27:22PM -0800, Darrick J. Wong wrote:
> On Thu, Dec 07, 2017 at 10:17:12PM -0600, Eric Sandeen wrote:
> > Some of these are more self-explanatory than others ("nci?").
> > Just mention the bit each one controls, and put them in order
> > while we're at it.  There are more comments about each bit
> > near its definition.
> > 
> > Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> > ---
> >  mkfs/xfs_mkfs.c | 22 +++++++++++-----------
> >  1 file changed, 11 insertions(+), 11 deletions(-)
> > 
> > diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
> > index f6e2fad..3f6315d 100644
> > --- a/mkfs/xfs_mkfs.c
> > +++ b/mkfs/xfs_mkfs.c
> > @@ -760,17 +760,17 @@ struct sb_feat_args {
> >  	int	log_version;
> >  	int	attr_version;
> >  	int	dir_version;
> > -	bool	inode_align;
> > -	bool	nci;
> > -	bool	lazy_sb_counters;
> > -	bool	projid32bit;
> > -	bool	crcs_enabled;
> > -	bool	dirftype;
> > -	bool	finobt;
> > -	bool	spinodes;
> > -	bool	rmapbt;
> > -	bool	reflink;
> > -	bool	parent_pointers;
> > +	bool	inode_align;		/* XFS_SB_VERSION_ALIGNBIT */
> > +	bool	nci;			/* XFS_SB_VERSION_BORGBIT */
> 
> Is there a compelling reason for leaving all these weird names?
> 
> nci, borg, asciici...
> 
> "names case insensitive"
> "buy organic ratty gallbladders"
> "ascii case insensitive"
> 
> They're all kinda terrible, but at least I get the gist with the third one.

Well, "borg" makes sense when you know the historic context:  the
asciici feature was implemented specifically to improve performance
on Samba fileserving to MS machines.....

But, yeah, I always planned to follow up the refacting merge with a
bunch of cleanups like this....

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com