Re: [PATCH 1/6] xfs: account for null transactions in bunmapi

Christoph Hellwig
2017-12-14T16:37:11Z

On Sun, Dec 10, 2017 at 06:16:20PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> In e1a4e37cc7b665 ("xfs: try to avoid blowing out the transaction
> reservation when bunmaping a shared extent"), we try to constrain the
> amount of real extents we unmap from the data fork in a given call so
> that we don't blow out transaction reservations.
>
> However, not all bunmapi operations require a transaction -- if we're
> only removing a delalloc extent, no transaction is needed, so we have to
> code against that.

Looks good for now. And reminds me that I need to submit my patch
to get rid of that special case :)

Reviewed-by: Christoph Hellwig <hch@lst.de>