public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] tests/xfs/040: document purpose
@ 2017-12-15 20:41 Luis R. Rodriguez
  2017-12-18 14:47 ` Bill O'Donnell
  0 siblings, 1 reply; 2+ messages in thread
From: Luis R. Rodriguez @ 2017-12-15 20:41 UTC (permalink / raw)
  To: fstests; +Cc: linux-xfs, linux-kernel, Luis R. Rodriguez

Getting xfs/040 to "pass" takes a bit of effort, however the effort
to require updating xfsprogs is purely an xfsprogs maintainer task
only. There no functional gain by users of xfs or a QA team to get
this test to pass. This is not trivial from the current description
so document this.

Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
---
 tests/xfs/040 | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tests/xfs/040 b/tests/xfs/040
index fadb888cbfaf..a0abc42f3720 100755
--- a/tests/xfs/040
+++ b/tests/xfs/040
@@ -3,6 +3,11 @@
 #
 # compare-libxfs test
 #
+# The purpose of this test is only to nag the maintainer of xfsprogs to try to
+# keep xfsprogs's libxfs files in sync with the latest kernel's libxfs. There
+# is no functional need for anyone to actually run this test to confirm
+# proper XFS functionalilty, this is an xfsprogs maintainer test.
+#
 #-----------------------------------------------------------------------
 # Copyright (c) 2000-2001 Silicon Graphics, Inc.  All Rights Reserved.
 #
-- 
2.15.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] tests/xfs/040: document purpose
  2017-12-15 20:41 [PATCH] tests/xfs/040: document purpose Luis R. Rodriguez
@ 2017-12-18 14:47 ` Bill O'Donnell
  0 siblings, 0 replies; 2+ messages in thread
From: Bill O'Donnell @ 2017-12-18 14:47 UTC (permalink / raw)
  To: Luis R. Rodriguez; +Cc: fstests, linux-xfs, linux-kernel

On Fri, Dec 15, 2017 at 12:41:18PM -0800, Luis R. Rodriguez wrote:
> Getting xfs/040 to "pass" takes a bit of effort, however the effort
> to require updating xfsprogs is purely an xfsprogs maintainer task
> only. There no functional gain by users of xfs or a QA team to get
> this test to pass. This is not trivial from the current description
> so document this.
> 
> Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>

Looks good...

Reviewed-by: Bill O'Donnell <billodo@redhat.com>

> ---
>  tests/xfs/040 | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/tests/xfs/040 b/tests/xfs/040
> index fadb888cbfaf..a0abc42f3720 100755
> --- a/tests/xfs/040
> +++ b/tests/xfs/040
> @@ -3,6 +3,11 @@
>  #
>  # compare-libxfs test
>  #
> +# The purpose of this test is only to nag the maintainer of xfsprogs to try to
> +# keep xfsprogs's libxfs files in sync with the latest kernel's libxfs. There
> +# is no functional need for anyone to actually run this test to confirm
> +# proper XFS functionalilty, this is an xfsprogs maintainer test.
> +#
>  #-----------------------------------------------------------------------
>  # Copyright (c) 2000-2001 Silicon Graphics, Inc.  All Rights Reserved.
>  #
> -- 
> 2.15.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-12-18 14:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-15 20:41 [PATCH] tests/xfs/040: document purpose Luis R. Rodriguez
2017-12-18 14:47 ` Bill O'Donnell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox