From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/4] xfs: track cowblocks separately in i_flags
Date: Thu, 21 Dec 2017 05:36:59 -0800 [thread overview]
Message-ID: <20171221133659.GA10079@infradead.org> (raw)
In-Reply-To: <151335787965.26575.17711793213679430025.stgit@magnolia>
> +static inline unsigned long
> +xfs_iflag_for_tag(
> + int tag)
> +{
> + switch (tag) {
> + case XFS_ICI_EOFBLOCKS_TAG:
> + return XFS_IEOFBLOCKS;
> + case XFS_ICI_COWBLOCKS_TAG:
> + return XFS_ICOWBLOCKS;
> + default:
> + ASSERT(0);
> + return 0;
> + }
> +}
I'd rather pass the flag explicitly to the functions that already
take the tag value.
Except for that the patch looks fine:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2017-12-21 13:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-15 17:11 [PATCH 0/4] xfs: more reflink fixes Darrick J. Wong
2017-12-15 17:11 ` [PATCH 1/4] xfs: track cowblocks separately in i_flags Darrick J. Wong
2017-12-19 0:12 ` Dave Chinner
2017-12-21 13:36 ` Christoph Hellwig [this message]
2017-12-15 17:11 ` [PATCH 2/4] xfs: don't be so eager to clear the cowblocks tag on truncate Darrick J. Wong
2017-12-19 0:12 ` Dave Chinner
2017-12-21 13:37 ` Christoph Hellwig
2017-12-15 17:11 ` [PATCH 3/4] xfs: remove leftover CoW reservations when remounting ro Darrick J. Wong
2017-12-19 0:17 ` Dave Chinner
2017-12-19 3:49 ` Darrick J. Wong
2017-12-19 4:37 ` Dave Chinner
2017-12-19 4:53 ` Darrick J. Wong
2017-12-19 6:46 ` Dave Chinner
2017-12-19 19:00 ` Darrick J. Wong
2017-12-19 20:55 ` Dave Chinner
2017-12-19 21:08 ` [PATCH v2 " Darrick J. Wong
2017-12-21 13:38 ` Christoph Hellwig
2017-12-15 17:11 ` [PATCH 4/4] xfs: set cowblocks tag for direct cow writes too Darrick J. Wong
2017-12-19 0:18 ` Dave Chinner
2017-12-21 13:39 ` Christoph Hellwig
2017-12-19 21:09 ` [PATCH 5/4] xfs: clean up cow mappings during fs data freeze Darrick J. Wong
2017-12-21 13:39 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171221133659.GA10079@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).