From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Aliaksei Karaliou <akaraliou.dev@gmail.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2] xfs: quota: fix missed destroy of qi_tree_lock
Date: Thu, 21 Dec 2017 13:21:36 -0800 [thread overview]
Message-ID: <20171221212136.GY12613@magnolia> (raw)
In-Reply-To: <20171221201743.18016-1-akaraliou.dev@gmail.com>
On Thu, Dec 21, 2017 at 11:17:42PM +0300, Aliaksei Karaliou wrote:
> xfs_qm_destroy_quotainfo() does not destroy quotainfo->qi_tree_lock
> while destroys quotainfo->qi_quotaofflock.
>
> Signed-off-by: Aliaksei Karaliou <akaraliou.dev@gmail.com>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> fs/xfs/xfs_qm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/xfs/xfs_qm.c b/fs/xfs/xfs_qm.c
> index ec952dfad359..d0053115427f 100644
> --- a/fs/xfs/xfs_qm.c
> +++ b/fs/xfs/xfs_qm.c
> @@ -736,6 +736,7 @@ xfs_qm_destroy_quotainfo(
> IRELE(qi->qi_pquotaip);
> qi->qi_pquotaip = NULL;
> }
> + mutex_destroy(&qi->qi_tree_lock);
> mutex_destroy(&qi->qi_quotaofflock);
> kmem_free(qi);
> mp->m_quotainfo = NULL;
> --
> 2.11.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-12-21 21:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-21 20:17 [PATCH 1/2] xfs: quota: fix missed destroy of qi_tree_lock Aliaksei Karaliou
2017-12-21 20:17 ` [PATCH 2/2] xfs: quota: check result of register_shrinker() Aliaksei Karaliou
2017-12-21 21:21 ` Darrick J. Wong
2017-12-21 21:48 ` Aliaksei Karaliou
2017-12-21 21:59 ` Darrick J. Wong
2017-12-21 21:21 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171221212136.GY12613@magnolia \
--to=darrick.wong@oracle.com \
--cc=akaraliou.dev@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).