From: Jan Kara <jack@suse.cz>
To: Dan Williams <dan.j.williams@intel.com>
Cc: akpm@linux-foundation.org, jack@suse.cz,
Matthew Wilcox <mawilcox@microsoft.com>,
linux-nvdimm@lists.01.org, linux-xfs@vger.kernel.org,
Jeff Moyer <jmoyer@redhat.com>,
linux-fsdevel@vger.kernel.org, ross.zwisler@linux.intel.com,
hch@lst.de
Subject: Re: [PATCH v4 15/18] mm, fs, dax: use page->mapping to warn if dma collides with truncate
Date: Thu, 4 Jan 2018 10:39:06 +0100 [thread overview]
Message-ID: <20180104093906.GC29010@quack2.suse.cz> (raw)
In-Reply-To: <151407704063.38751.15403501871756055025.stgit@dwillia2-desk3.amr.corp.intel.com>
On Sat 23-12-17 16:57:20, Dan Williams wrote:
> Catch cases where truncate encounters pages that are still under active
> dma. This warning is a canary for potential data corruption as truncated
> blocks could be allocated to a new file while the device is still
> perform i/o.
>
> Here is an example of a collision that this implementation catches:
>
> WARNING: CPU: 2 PID: 1286 at fs/dax.c:343 dax_disassociate_entry+0x55/0x80
> [..]
> Call Trace:
> __dax_invalidate_mapping_entry+0x6c/0xf0
> dax_delete_mapping_entry+0xf/0x20
> truncate_exceptional_pvec_entries.part.12+0x1af/0x200
> truncate_inode_pages_range+0x268/0x970
> ? tlb_gather_mmu+0x10/0x20
> ? up_write+0x1c/0x40
> ? unmap_mapping_range+0x73/0x140
> xfs_free_file_space+0x1b6/0x5b0 [xfs]
> ? xfs_file_fallocate+0x7f/0x320 [xfs]
> ? down_write_nested+0x40/0x70
> ? xfs_ilock+0x21d/0x2f0 [xfs]
> xfs_file_fallocate+0x162/0x320 [xfs]
> ? rcu_read_lock_sched_held+0x3f/0x70
> ? rcu_sync_lockdep_assert+0x2a/0x50
> ? __sb_start_write+0xd0/0x1b0
> ? vfs_fallocate+0x20c/0x270
> vfs_fallocate+0x154/0x270
> SyS_fallocate+0x43/0x80
> entry_SYSCALL_64_fastpath+0x1f/0x96
>
> Cc: Jan Kara <jack@suse.cz>
> Cc: Jeff Moyer <jmoyer@redhat.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Matthew Wilcox <mawilcox@microsoft.com>
> Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Looks good to me. You can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2018-01-04 9:39 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-24 0:56 [PATCH v4 00/18] dax: fix dma vs truncate/hole-punch Dan Williams
2017-12-24 0:56 ` [PATCH v4 01/18] mm, dax: introduce pfn_t_special() Dan Williams
2018-01-04 8:16 ` Christoph Hellwig
2017-12-24 0:56 ` [PATCH v4 02/18] ext4: auto disable dax instead of failing mount Dan Williams
2018-01-03 14:20 ` Jan Kara
2017-12-24 0:56 ` [PATCH v4 03/18] ext2: " Dan Williams
2018-01-03 14:21 ` Jan Kara
2017-12-24 0:56 ` [PATCH v4 04/18] dax: require 'struct page' by default for filesystem dax Dan Williams
2018-01-03 15:29 ` Jan Kara
2018-01-04 8:16 ` Christoph Hellwig
2018-01-08 11:58 ` Gerald Schaefer
2017-12-24 0:56 ` [PATCH v4 05/18] dax: stop using VM_MIXEDMAP for dax Dan Williams
2018-01-03 15:27 ` Jan Kara
2017-12-24 0:56 ` [PATCH v4 06/18] dax: stop using VM_HUGEPAGE " Dan Williams
2017-12-24 0:56 ` [PATCH v4 07/18] dax: store pfns in the radix Dan Williams
2017-12-27 0:17 ` Ross Zwisler
2018-01-02 20:15 ` Dan Williams
2018-01-03 15:39 ` Jan Kara
2017-12-24 0:56 ` [PATCH v4 08/18] tools/testing/nvdimm: add 'bio_delay' mechanism Dan Williams
2017-12-27 18:08 ` Ross Zwisler
2018-01-02 20:35 ` Dan Williams
2018-01-02 21:44 ` Dave Chinner
2018-01-02 21:51 ` Dan Williams
2018-01-03 15:46 ` Jan Kara
2018-01-03 20:37 ` Jeff Moyer
2017-12-24 0:56 ` [PATCH v4 09/18] mm, dax: enable filesystems to trigger dev_pagemap ->page_free callbacks Dan Williams
2018-01-04 8:20 ` Christoph Hellwig
2017-12-24 0:56 ` [PATCH v4 10/18] mm, dev_pagemap: introduce CONFIG_DEV_PAGEMAP_OPS Dan Williams
2018-01-04 8:25 ` Christoph Hellwig
2017-12-24 0:56 ` [PATCH v4 11/18] fs, dax: introduce DEFINE_FSDAX_AOPS Dan Williams
2017-12-27 5:29 ` Matthew Wilcox
2018-01-02 20:21 ` Dan Williams
2018-01-03 16:05 ` Jan Kara
2018-01-04 8:27 ` Christoph Hellwig
2018-01-02 21:41 ` Dave Chinner
2017-12-24 0:57 ` [PATCH v4 12/18] xfs: use DEFINE_FSDAX_AOPS Dan Williams
2018-01-02 21:15 ` Darrick J. Wong
2018-01-02 21:40 ` Dan Williams
2018-01-03 16:09 ` Jan Kara
2018-01-04 8:28 ` Christoph Hellwig
2017-12-24 0:57 ` [PATCH v4 13/18] ext4: " Dan Williams
2018-01-04 8:29 ` Christoph Hellwig
2017-12-24 0:57 ` [PATCH v4 14/18] ext2: " Dan Williams
2018-01-04 8:29 ` Christoph Hellwig
2017-12-24 0:57 ` [PATCH v4 15/18] mm, fs, dax: use page->mapping to warn if dma collides with truncate Dan Williams
2018-01-04 8:30 ` Christoph Hellwig
2018-01-04 9:39 ` Jan Kara [this message]
2017-12-24 0:57 ` [PATCH v4 16/18] wait_bit: introduce {wait_on,wake_up}_atomic_one Dan Williams
2018-01-04 8:30 ` Christoph Hellwig
2017-12-24 0:57 ` [PATCH v4 17/18] mm, fs, dax: dax_flush_dma, handle dma vs block-map-change collisions Dan Williams
2018-01-04 8:31 ` Christoph Hellwig
2018-01-04 11:12 ` Jan Kara
2018-01-07 21:58 ` Dan Williams
2018-01-08 13:50 ` Jan Kara
2018-03-08 17:02 ` Dan Williams
2018-03-09 12:56 ` Jan Kara
2018-03-09 16:15 ` Dan Williams
2018-03-09 17:26 ` Dan Williams
2017-12-24 0:57 ` [PATCH v4 18/18] xfs, dax: wire up dax_flush_dma support via a new xfs_sync_dma helper Dan Williams
2018-01-02 21:07 ` Darrick J. Wong
2018-01-02 23:00 ` Dave Chinner
2018-01-03 2:21 ` Dan Williams
2018-01-03 7:51 ` Dave Chinner
2018-01-04 8:34 ` Christoph Hellwig
2018-01-04 8:33 ` Christoph Hellwig
2018-01-04 8:17 ` [PATCH v4 00/18] dax: fix dma vs truncate/hole-punch Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180104093906.GC29010@quack2.suse.cz \
--to=jack@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=hch@lst.de \
--cc=jmoyer@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mawilcox@microsoft.com \
--cc=ross.zwisler@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).