Re: [PATCH v3] xfs: clarify units in the failed metadata io message

Dave Chinner
2018-01-08T22:57:09Z

On Mon, Jan 08, 2018 at 02:38:45PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> If a metadata IO error happens, we report the location of the failed IO
> request in units of daddrs. However, the printk message misleads people
> into thinking that the units are fs blocks, so fix the reported units.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> v3: fix only the units reporting, don't print the caller
> v2: fix more messages

Looks good.

Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com