From: Richard Wareing <rwareing@fb.com>
To: fstests@vger.kernel.org
Cc: darrick.wong@oracle.com, eguan@redhat.com, linux-xfs@vger.kernel.org
Subject: [PATCH v3 0/3] Fix/harden "quick" tests for realtime subvolumes
Date: Wed, 10 Jan 2018 19:08:58 -0800 [thread overview]
Message-ID: <20180111030901.1961285-1-rwareing@fb.com> (raw)
Applies clean to commit 95c924c65113d2b706436d8cd09cd391eddb795a.
Kernel: 4.14-rc8 (Commit 39dae59d66acd86d1de24294bd2f343fd5e7a625)
MKFS_OPTIONS="-m finobt=1,crc=1,reflink=1"
Updated patch set to address comments made by reviewers. Changes are noted
on the patches.
A couple of tests (e.g. tests/xfs/191-input-validation) which work for Eryu
still fail for me, but I'll comment on those w/ sample output on the mailing
list, as I might have some toolchain issue on my end.
==== Original Cover Letter ===
Some tests have issues when being run with realtime subvolumes. This patch
set aims to harden fs tests so we can get reliable/reproducible test runs
with fstests for realtime subvolumes.
Two new _require functions are introduced along with a new flag to
automatically set the rtinherit=1 option upon mkfs'ing.
The problems I found were usually one of:
1. Snapshot + subsequent test being performed without regard to the realtime
subvolume.
2. Use of functions which are not supported by realtime devices. Not setting
rtinherit on scratch devices for these cases fixes these tests. Non-scratch
cases are more tricky since we don't control what goes into the MKFS_OPTIONS
variable.
3. xfs_repair being used directly without checking for RT devices.
After fixing these cases, you get 86 good "quick: xfs tests & 180 good "quick"
generic tests with the bulk are not run due to the lack of reflink and/or quota
support on realtime scratch targets.
P.S I haven't forgotten about the non-"quick" tests, but I had to start
somewhere, and break this up a bit into a more manageable problem.
Richard Wareing (3):
xfs/realtime: Add require_no_realtime function
xfs/realtime: Default rtinherit=1, add _require_no_rtinherit function
xfs/realtime: Fix direct invocations of xfs_repair
common/rc | 29 +++++++++++++++++++++++++++--
tests/generic/250 | 3 +++
tests/generic/252 | 3 +++
tests/generic/441 | 3 +++
tests/xfs/070 | 5 ++++-
tests/xfs/077 | 2 ++
tests/xfs/170 | 1 +
tests/xfs/189 | 1 +
tests/xfs/284 | 2 ++
tests/xfs/291 | 5 ++++-
10 files changed, 50 insertions(+), 4 deletions(-)
--
2.9.5
next reply other threads:[~2018-01-11 3:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 3:08 Richard Wareing [this message]
2018-01-11 3:08 ` [PATCH v3 1/3] xfs/realtime: Add require_no_realtime function Richard Wareing
2018-01-11 4:10 ` Darrick J. Wong
2018-01-11 21:22 ` Richard Wareing
2018-01-11 3:09 ` [PATCH v3 2/3] xfs/realtime: Default rtinherit=1, add _require_no_rtinherit function Richard Wareing
2018-01-11 4:06 ` Darrick J. Wong
2018-01-11 21:27 ` Richard Wareing
2018-01-11 3:09 ` [PATCH v3 3/3] xfs/realtime: Fix direct invocations of xfs_repair Richard Wareing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180111030901.1961285-1-rwareing@fb.com \
--to=rwareing@fb.com \
--cc=darrick.wong@oracle.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox