From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 3/8] xfs: remove unused buf_fsprivate3
Date: Thu, 11 Jan 2018 11:44:23 -0800 [thread overview]
Message-ID: <20180111194423.GC5602@magnolia> (raw)
In-Reply-To: <1515699458-6925-4-git-send-email-sandeen@sandeen.net>
On Thu, Jan 11, 2018 at 01:37:33PM -0600, Eric Sandeen wrote:
> The buf_fsprivate3 field has no actual use, other than a pointless
> "if it's not set, set it" in xfs_buf_item_init; nobody cares after
> that. Remove it.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> libxfs/libxfs_io.h | 4 ----
> libxfs/logitem.c | 2 --
> 2 files changed, 6 deletions(-)
>
> diff --git a/libxfs/libxfs_io.h b/libxfs/libxfs_io.h
> index 5acd3df..2fce04d 100644
> --- a/libxfs/libxfs_io.h
> +++ b/libxfs/libxfs_io.h
> @@ -70,7 +70,6 @@ typedef struct xfs_buf {
> unsigned int b_recur;
> void *b_fspriv;
> void *b_transp;
> - void *b_fsprivate3;
> void *b_addr;
> int b_error;
> const struct xfs_buf_ops *b_ops;
> @@ -111,9 +110,6 @@ enum xfs_buf_flags_t { /* b_flags bits */
> #define XFS_BUF_SET_ADDR(bp,blk) ((bp)->b_bn = (blk))
> #define XFS_BUF_SET_COUNT(bp,cnt) ((bp)->b_bcount = (cnt))
>
> -#define XFS_BUF_FSPRIVATE3(bp,type) ((type)(bp)->b_fsprivate3)
> -#define XFS_BUF_SET_FSPRIVATE3(bp,val) (bp)->b_fsprivate3 = (void *)(val)
> -
> #define XFS_BUF_SET_PRIORITY(bp,pri) cache_node_set_priority( \
> libxfs_bcache, \
> (struct cache_node *)(bp), \
> diff --git a/libxfs/logitem.c b/libxfs/logitem.c
> index 0c183b5..0c50fcf 100644
> --- a/libxfs/logitem.c
> +++ b/libxfs/logitem.c
> @@ -96,8 +96,6 @@ xfs_buf_item_init(
> * the first. If we do already have one, there is
> * nothing to do here so return.
> */
> - if (XFS_BUF_FSPRIVATE3(bp, xfs_mount_t *) != mp)
> - XFS_BUF_SET_FSPRIVATE3(bp, mp);
> XFS_BUF_SET_BDSTRAT_FUNC(bp, xfs_bdstrat_cb);
> if (bp->b_fspriv != NULL) {
> lip = bp->b_fspriv;
> --
> 1.8.3.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-01-11 19:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 19:37 [PATCH 0/8] libxfs: cleanup & leak detection Eric Sandeen
2018-01-11 19:37 ` [PATCH 1/8] xfs: remove wrappers around b_fspriv Eric Sandeen
2018-01-11 19:42 ` Darrick J. Wong
2018-01-11 19:37 ` [PATCH 2/8] xfs: add a proper transaction pointer to struct xfs_buf Eric Sandeen
2018-01-11 19:43 ` Darrick J. Wong
2018-01-11 19:37 ` [PATCH 3/8] xfs: remove unused buf_fsprivate3 Eric Sandeen
2018-01-11 19:44 ` Darrick J. Wong [this message]
2018-01-11 19:37 ` [PATCH 4/8] libxfs: use a memory zone for transactions Eric Sandeen
2018-01-11 19:48 ` Darrick J. Wong
2018-01-25 19:01 ` [PATCH 4/8 V2] " Eric Sandeen
2018-01-25 19:22 ` Darrick J. Wong
2018-01-11 19:37 ` [PATCH 5/8] libxfs: use a memory zone for log items Eric Sandeen
2018-01-11 19:49 ` Darrick J. Wong
2018-01-11 19:37 ` [PATCH 6/8] libxfs: manage xfs_buf_zone count within cache Eric Sandeen
2018-01-11 20:20 ` Darrick J. Wong
2018-01-11 20:48 ` Eric Sandeen
2018-01-11 22:09 ` Dave Chinner
2018-01-11 19:37 ` [PATCH 7/8] libxfs: add function to free all bufferse in bcache Eric Sandeen
2018-01-11 20:05 ` Darrick J. Wong
2018-01-11 20:11 ` Eric Sandeen
2018-01-11 20:22 ` Darrick J. Wong
2018-01-11 19:37 ` [PATCH 8/8] libxfs: Catch non-empty zones on destroy Eric Sandeen
2018-01-11 20:29 ` Darrick J. Wong
2018-01-11 23:42 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180111194423.GC5602@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox