From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs_logprint: fix v3 inode formatting
Date: Fri, 12 Jan 2018 08:45:52 -0800 [thread overview]
Message-ID: <20180112164552.GV5602@magnolia> (raw)
In-Reply-To: <831989ff-14a7-5c22-2b9c-457033a99945@redhat.com>
On Fri, Jan 12, 2018 at 10:32:38AM -0600, Eric Sandeen wrote:
> Line up flags2/cowextsize line with all the others, using
> tabs.
>
> Fixes: 1fe708d60 ("xfs_logprint: support cowextsize reporting in log contents")
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
>
> diff --git a/logprint/log_print_all.c b/logprint/log_print_all.c
> index c80bf34..cdaf77b 100644
> --- a/logprint/log_print_all.c
> +++ b/logprint/log_print_all.c
> @@ -273,7 +273,7 @@ xlog_recover_print_inode_core(
> (int)di->di_forkoff, di->di_dmevmask, (int)di->di_dmstate,
> (int)di->di_flags, di->di_gen);
> if (di->di_version == 3) {
> - printf(_("flags2 0x%llx cowextsize 0x%x\n"),
> + printf(_(" flags2 0x%llx cowextsize 0x%x\n"),
> (unsigned long long)di->di_flags2, di->di_cowextsize);
> }
> }
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2018-01-12 16:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 16:32 [PATCH] xfs_logprint: fix v3 inode formatting Eric Sandeen
2018-01-12 16:45 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180112164552.GV5602@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox