From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs: fix non-debug build compiler warnings
Date: Thu, 18 Jan 2018 11:52:03 +1100 [thread overview]
Message-ID: <20180118005203.GL6304@dastard> (raw)
In-Reply-To: <20180117164102.GE25805@magnolia>
On Wed, Jan 17, 2018 at 08:41:02AM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@djwong.org>
>
> Fix compiler warning on non-debug build
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> fs/xfs/xfs_dquot_item.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/fs/xfs/xfs_dquot_item.c b/fs/xfs/xfs_dquot_item.c
> index e564f11..51ee848 100644
> --- a/fs/xfs/xfs_dquot_item.c
> +++ b/fs/xfs/xfs_dquot_item.c
> @@ -150,10 +150,7 @@ xfs_dquot_item_error(
> struct xfs_log_item *lip,
> struct xfs_buf *bp)
> {
> - struct xfs_dquot *dqp;
> -
> - dqp = DQUOT_ITEM(lip)->qli_dquot;
> - ASSERT(!completion_done(&dqp->q_flush));
> + ASSERT(!completion_done(&DQUOT_ITEM(lip)->qli_dquot->q_flush));
> xfs_set_li_failed(lip, bp);
Looks fine.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2018-01-18 0:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 16:41 [PATCH] xfs: fix non-debug build compiler warnings Darrick J. Wong
2018-01-18 0:52 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180118005203.GL6304@dastard \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox