* [PATCH] xfs: fix non-debug build compiler warnings
@ 2018-01-17 16:41 Darrick J. Wong
2018-01-18 0:52 ` Dave Chinner
0 siblings, 1 reply; 2+ messages in thread
From: Darrick J. Wong @ 2018-01-17 16:41 UTC (permalink / raw)
To: xfs
From: Darrick J. Wong <djwong@djwong.org>
Fix compiler warning on non-debug build
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
fs/xfs/xfs_dquot_item.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/fs/xfs/xfs_dquot_item.c b/fs/xfs/xfs_dquot_item.c
index e564f11..51ee848 100644
--- a/fs/xfs/xfs_dquot_item.c
+++ b/fs/xfs/xfs_dquot_item.c
@@ -150,10 +150,7 @@ xfs_dquot_item_error(
struct xfs_log_item *lip,
struct xfs_buf *bp)
{
- struct xfs_dquot *dqp;
-
- dqp = DQUOT_ITEM(lip)->qli_dquot;
- ASSERT(!completion_done(&dqp->q_flush));
+ ASSERT(!completion_done(&DQUOT_ITEM(lip)->qli_dquot->q_flush));
xfs_set_li_failed(lip, bp);
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfs: fix non-debug build compiler warnings
2018-01-17 16:41 [PATCH] xfs: fix non-debug build compiler warnings Darrick J. Wong
@ 2018-01-18 0:52 ` Dave Chinner
0 siblings, 0 replies; 2+ messages in thread
From: Dave Chinner @ 2018-01-18 0:52 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: xfs
On Wed, Jan 17, 2018 at 08:41:02AM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@djwong.org>
>
> Fix compiler warning on non-debug build
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> fs/xfs/xfs_dquot_item.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/fs/xfs/xfs_dquot_item.c b/fs/xfs/xfs_dquot_item.c
> index e564f11..51ee848 100644
> --- a/fs/xfs/xfs_dquot_item.c
> +++ b/fs/xfs/xfs_dquot_item.c
> @@ -150,10 +150,7 @@ xfs_dquot_item_error(
> struct xfs_log_item *lip,
> struct xfs_buf *bp)
> {
> - struct xfs_dquot *dqp;
> -
> - dqp = DQUOT_ITEM(lip)->qli_dquot;
> - ASSERT(!completion_done(&dqp->q_flush));
> + ASSERT(!completion_done(&DQUOT_ITEM(lip)->qli_dquot->q_flush));
> xfs_set_li_failed(lip, bp);
Looks fine.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-18 0:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-17 16:41 [PATCH] xfs: fix non-debug build compiler warnings Darrick J. Wong
2018-01-18 0:52 ` Dave Chinner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox