public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: hch@lst.de, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/2] xfs: try to unshare extents before granting pnfs leases
Date: Thu, 18 Jan 2018 15:15:13 +0100	[thread overview]
Message-ID: <20180118141513.GA22992@lst.de> (raw)
In-Reply-To: <151626135947.25794.13152244142083119314.stgit@magnolia>

On Wed, Jan 17, 2018 at 11:42:39PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Try to unshare an extent before granting a lease to pnfs; if this isn't
> possible, then bail out.


I don't like this at all.  The block and scsi layout protocols actually
have support for reflinks, someone just needs to implement it..

But until that is implemented I'd rather fail getting a layout than
starting a potentially very long running unshare.

  reply	other threads:[~2018-01-18 14:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-18  7:42 [PATCH 0/2] xfs: pnfs/reflink fixes Darrick J. Wong
2018-01-18  7:42 ` [PATCH 1/2] xfs: reflink should break pnfs leases before sharing blocks Darrick J. Wong
2018-01-18 14:26   ` Christoph Hellwig
2018-01-18  7:42 ` [PATCH 2/2] xfs: try to unshare extents before granting pnfs leases Darrick J. Wong
2018-01-18 14:15   ` Christoph Hellwig [this message]
2018-01-18 17:02     ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180118141513.GA22992@lst.de \
    --to=hch@lst.de \
    --cc=darrick.wong@oracle.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox