From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eryu Guan <eguan@redhat.com>
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH 4/5] xfs/24[356]: checking cow fork bmap requires CONFIG_XFS_DEBUG=y
Date: Thu, 25 Jan 2018 16:11:50 -0800 [thread overview]
Message-ID: <20180126001150.GE9359@magnolia> (raw)
In-Reply-To: <20180125081753.GH18267@eguan.usersys.redhat.com>
On Thu, Jan 25, 2018 at 04:17:53PM +0800, Eryu Guan wrote:
> On Wed, Jan 24, 2018 at 03:53:41PM -0800, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > These tests requires XFS debugging functionality, so test for that.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> > ---
> > tests/xfs/243 | 2 ++
> > tests/xfs/245 | 2 ++
> > tests/xfs/246 | 2 ++
> > 3 files changed, 6 insertions(+)
> >
> >
> > diff --git a/tests/xfs/243 b/tests/xfs/243
> > index 0bb69c4..1e6ab5a 100755
> > --- a/tests/xfs/243
> > +++ b/tests/xfs/243
> > @@ -49,10 +49,12 @@ _cleanup()
> > . ./common/rc
> > . ./common/filter
> > . ./common/reflink
> > +. ./common/xfs
>
> This file should be included already by common/rc based on $FSTYP, no
> need to source it again in test. I'd remove it from all three tests on
> commit.
Ok. Sorry I missed that subtlety.
--D
> Thanks,
> Eryu
next prev parent reply other threads:[~2018-01-26 0:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 23:53 [PATCH 0/5] xfstests: fixes and reflink quota tests Darrick J. Wong
2018-01-24 23:53 ` [PATCH 1/5] common/rc: report kmemleak errors Darrick J. Wong
2018-01-24 23:53 ` [PATCH 2/5] xfs/122: fix xfs header ordering problems Darrick J. Wong
2018-01-24 23:53 ` [PATCH 3/5] generic/403: don't spew '$GETFATTR_PROG: Killed' messages Darrick J. Wong
2018-01-25 7:58 ` Eryu Guan
2018-01-24 23:53 ` [PATCH 4/5] xfs/24[356]: checking cow fork bmap requires CONFIG_XFS_DEBUG=y Darrick J. Wong
2018-01-25 8:17 ` Eryu Guan
2018-01-26 0:11 ` Darrick J. Wong [this message]
2018-01-24 23:53 ` [PATCH 5/5] xfs: regression tests for reflink quota bugs Darrick J. Wong
2018-01-26 6:49 ` Eryu Guan
2018-01-26 7:00 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180126001150.GE9359@magnolia \
--to=darrick.wong@oracle.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).