From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: bfoster@redhat.com, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 5/7] iomap: warn on zero-length mappings
Date: Sat, 27 Jan 2018 10:04:39 -0800 [thread overview]
Message-ID: <20180127180439.GH9068@magnolia> (raw)
In-Reply-To: <20180127073450.GE11515@infradead.org>
On Fri, Jan 26, 2018 at 11:34:50PM -0800, Christoph Hellwig wrote:
> > - if (WARN_ON(iomap.offset > pos))
> > + if (WARN_ON(iomap.offset > pos) || WARN_ON(iomap.length == 0))
>
> Btw, shouldn't this be one WARN_ON with both conditions inside?
> It's not like we can spot which one it was based on the output
> anyway.
>
> Alternatively just have two conditionals, which allows us to spot
> what went wrong.
Ah, right, I forgot that WARN_ON doesn't print the failing condition
unlike our ASSERT.
--D
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-01-27 18:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-27 1:10 [PATCH v3 0/7] xfs: reflink/scrub/quota fixes Darrick J. Wong
2018-01-27 1:10 ` [PATCH 1/7] xfs: reflink should break pnfs leases before sharing blocks Darrick J. Wong
2018-01-27 7:31 ` Christoph Hellwig
2018-01-27 1:10 ` [PATCH 2/7] xfs: allow xfs_lock_two_inodes to take different EXCL/SHARED modes Darrick J. Wong
2018-01-27 7:32 ` Christoph Hellwig
2018-01-27 1:10 ` [PATCH 3/7] xfs: only grab shared inode locks for source file during reflink Darrick J. Wong
2018-01-27 7:33 ` Christoph Hellwig
2018-01-27 1:10 ` [PATCH 4/7] xfs: treat CoW fork operations as delalloc for quota accounting Darrick J. Wong
2018-01-27 7:33 ` Christoph Hellwig
2018-01-29 12:26 ` Brian Foster
2018-01-29 23:00 ` Darrick J. Wong
2018-01-30 11:48 ` Brian Foster
2018-01-27 1:10 ` [PATCH 5/7] iomap: warn on zero-length mappings Darrick J. Wong
2018-01-27 7:34 ` Christoph Hellwig
2018-01-27 18:04 ` Darrick J. Wong [this message]
2018-01-27 18:08 ` [PATCH v2 " Darrick J. Wong
2018-01-27 1:10 ` [PATCH 6/7] xfs: check reflink allocation mappings Darrick J. Wong
2018-01-27 7:35 ` Christoph Hellwig
2018-01-27 1:10 ` [PATCH 7/7] xfs: don't screw up direct writes when freesp is fragmented Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180127180439.GH9068@magnolia \
--to=darrick.wong@oracle.com \
--cc=bfoster@redhat.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox