From: Bill O'Donnell <billodo@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: xfs <linux-xfs@vger.kernel.org>,
Dave Chinner <david@fromorbit.com>,
Eric Sandeen <sandeen@redhat.com>
Subject: Re: [PATCH] xfs: remove experimental tag for reverse mapping
Date: Wed, 31 Jan 2018 17:32:57 -0600 [thread overview]
Message-ID: <20180131233257.GA20639@redhat.com> (raw)
In-Reply-To: <20180131174913.GE4849@magnolia>
On Wed, Jan 31, 2018 at 09:49:13AM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Reverse mapping has had a while to soak, so remove the experimental tag.
> Now that we've landed space metadata cross-referencing in scrub, the
> feature actually has a purpose.
>
> Reject rmap filesystems with an rt device until the code to support it
> is actually implemented.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Bill O'Donnell <billodo@redhat.com>
> ---
> fs/xfs/xfs_super.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index f3e0001..f436eec 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -1684,12 +1684,10 @@ xfs_fs_fill_super(
> if (xfs_sb_version_hasrmapbt(&mp->m_sb)) {
> if (mp->m_sb.sb_rblocks) {
> xfs_alert(mp,
> - "EXPERIMENTAL reverse mapping btree not compatible with realtime device!");
> + "reverse mapping btree not compatible with realtime device!");
> error = -EINVAL;
> goto out_filestream_unmount;
> }
> - xfs_alert(mp,
> - "EXPERIMENTAL reverse mapping btree feature enabled. Use at your own risk!");
> }
>
> error = xfs_mountfs(mp);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-01-31 23:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-31 17:49 [PATCH] xfs: remove experimental tag for reverse mapping Darrick J. Wong
2018-01-31 23:32 ` Bill O'Donnell [this message]
2018-01-31 23:48 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180131233257.GA20639@redhat.com \
--to=billodo@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox