From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: xfs <linux-xfs@vger.kernel.org>
Subject: [PATCH] xfs_scrub: log operational messages when interactive
Date: Thu, 1 Feb 2018 10:17:31 -0800 [thread overview]
Message-ID: <20180201181731.GQ4849@magnolia> (raw)
From: Darrick J. Wong <darrick.wong@oracle.com>
Record the output of an interactive session in the system log so that
future support requests can get a better picture of what happened.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
scrub/common.c | 37 +++++++++++++++++++++++++++++++++++++
1 file changed, 37 insertions(+)
diff --git a/scrub/common.c b/scrub/common.c
index 18171d1..7af7677 100644
--- a/scrub/common.c
+++ b/scrub/common.c
@@ -21,6 +21,7 @@
#include <pthread.h>
#include <stdbool.h>
#include <sys/statvfs.h>
+#include <syslog.h>
#include "platform_defs.h"
#include "xfs.h"
#include "xfs_fs.h"
@@ -29,6 +30,8 @@
#include "common.h"
#include "progress.h"
+extern char *progname;
+
/*
* Reporting Status to the Console
*
@@ -62,6 +65,12 @@ static const char *err_str[] = {
[S_INFO] = "Info",
};
+static int log_level[] = {
+ [S_ERROR] = LOG_ERR,
+ [S_WARN] = LOG_WARNING,
+ [S_INFO] = LOG_INFO,
+};
+
/* If stream is a tty, clear to end of line to clean up progress bar. */
static inline const char *stream_start(FILE *stream)
{
@@ -71,6 +80,8 @@ static inline const char *stream_start(FILE *stream)
}
/* Print a warning string and some warning text. */
+#define LOG_BUFSZ 4096
+#define LOGNAME_BUFSZ 256
void
__str_out(
struct scrub_ctx *ctx,
@@ -103,6 +114,32 @@ __str_out(
va_end(args);
}
+ /* If we're running interactively, log the message to syslog too. */
+ if (isatty(fileno(stdin))) {
+ char logname[LOGNAME_BUFSZ];
+
+ snprintf(logname, LOGNAME_BUFSZ, "%s@%s", progname,
+ ctx->mntpoint);
+ openlog(logname, LOG_PID, LOG_DAEMON);
+
+ if (error) {
+ syslog(LOG_ERR, "%s: %s: %s.",
+ _(err_str[level]), descr,
+ strerror_r(error, buf, DESCR_BUFSZ));
+ } else {
+ char buf[LOG_BUFSZ];
+ int sz;
+
+ sz = snprintf(buf, LOG_BUFSZ, "%s: %s: ",
+ _(err_str[level]), descr);
+ va_start(args, format);
+ vsnprintf(buf + sz, LOG_BUFSZ - sz, format, args);
+ va_end(args);
+ syslog(log_level[level], "%s", buf);
+ }
+ closelog();
+ }
+
if (debug)
fprintf(stream, _(" (%s line %d)"), file, line);
fprintf(stream, "\n");
reply other threads:[~2018-02-01 18:17 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180201181731.GQ4849@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).