* [PATCH] xfs: don't allow DAX on reflink filesystems
@ 2018-01-31 22:23 Darrick J. Wong
2018-01-31 23:11 ` Bill O'Donnell
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Darrick J. Wong @ 2018-01-31 22:23 UTC (permalink / raw)
To: xfs; +Cc: Dave Chinner, Eric Sandeen
From: Darrick J. Wong <darrick.wong@oracle.com>
Now that reflink is no longer experimental, reject attempts to mount
with DAX until that whole mess gets sorted out.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
fs/xfs/xfs_super.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
index f436eec..fd34cf2 100644
--- a/fs/xfs/xfs_super.c
+++ b/fs/xfs/xfs_super.c
@@ -1666,9 +1666,12 @@ xfs_fs_fill_super(
"DAX unsupported by block device. Turning off DAX.");
mp->m_flags &= ~XFS_MOUNT_DAX;
}
- if (xfs_sb_version_hasreflink(&mp->m_sb))
+ if (xfs_sb_version_hasreflink(&mp->m_sb)) {
xfs_alert(mp,
"DAX and reflink cannot be used together!");
+ error = -EINVAL;
+ goto out_filestream_unmount;
+ }
}
if (mp->m_flags & XFS_MOUNT_DISCARD) {
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] xfs: don't allow DAX on reflink filesystems
2018-01-31 22:23 [PATCH] xfs: don't allow DAX on reflink filesystems Darrick J. Wong
@ 2018-01-31 23:11 ` Bill O'Donnell
2018-01-31 23:17 ` Bill O'Donnell
2018-01-31 23:52 ` Dave Chinner
2018-02-02 9:51 ` Christoph Hellwig
2 siblings, 1 reply; 7+ messages in thread
From: Bill O'Donnell @ 2018-01-31 23:11 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: xfs, Dave Chinner, Eric Sandeen
On Wed, Jan 31, 2018 at 02:23:24PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Now that reflink is no longer experimental, reject attempts to mount
> with DAX until that whole mess gets sorted out.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
nit: Check alignment of the warning message (probably ok?)...
Reviewed-by: Bill O'Donnell <billodo@redhat.com>
> ---
> fs/xfs/xfs_super.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index f436eec..fd34cf2 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -1666,9 +1666,12 @@ xfs_fs_fill_super(
> "DAX unsupported by block device. Turning off DAX.");
> mp->m_flags &= ~XFS_MOUNT_DAX;
> }
> - if (xfs_sb_version_hasreflink(&mp->m_sb))
> + if (xfs_sb_version_hasreflink(&mp->m_sb)) {
> xfs_alert(mp,
> "DAX and reflink cannot be used together!");
> + error = -EINVAL;
> + goto out_filestream_unmount;
> + }
> }
>
> if (mp->m_flags & XFS_MOUNT_DISCARD) {
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] xfs: don't allow DAX on reflink filesystems
2018-01-31 23:11 ` Bill O'Donnell
@ 2018-01-31 23:17 ` Bill O'Donnell
0 siblings, 0 replies; 7+ messages in thread
From: Bill O'Donnell @ 2018-01-31 23:17 UTC (permalink / raw)
To: Darrick J. Wong, xfs, Dave Chinner, Eric Sandeen
On Wed, Jan 31, 2018 at 05:11:25PM -0600, Bill O'Donnell wrote:
> On Wed, Jan 31, 2018 at 02:23:24PM -0800, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > Now that reflink is no longer experimental, reject attempts to mount
> > with DAX until that whole mess gets sorted out.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
>
> nit: Check alignment of the warning message (probably ok?)...
nevermind. Alignment wasn't in your change. :)
Reviewed-by: Bill O'Donnell <billodo@redhat.com>
>
> Reviewed-by: Bill O'Donnell <billodo@redhat.com>
>
> > ---
> > fs/xfs/xfs_super.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> > index f436eec..fd34cf2 100644
> > --- a/fs/xfs/xfs_super.c
> > +++ b/fs/xfs/xfs_super.c
> > @@ -1666,9 +1666,12 @@ xfs_fs_fill_super(
> > "DAX unsupported by block device. Turning off DAX.");
> > mp->m_flags &= ~XFS_MOUNT_DAX;
> > }
> > - if (xfs_sb_version_hasreflink(&mp->m_sb))
> > + if (xfs_sb_version_hasreflink(&mp->m_sb)) {
> > xfs_alert(mp,
> > "DAX and reflink cannot be used together!");
> > + error = -EINVAL;
> > + goto out_filestream_unmount;
> > + }
> > }
> >
> > if (mp->m_flags & XFS_MOUNT_DISCARD) {
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] xfs: don't allow DAX on reflink filesystems
2018-01-31 22:23 [PATCH] xfs: don't allow DAX on reflink filesystems Darrick J. Wong
2018-01-31 23:11 ` Bill O'Donnell
@ 2018-01-31 23:52 ` Dave Chinner
2018-02-02 9:51 ` Christoph Hellwig
2 siblings, 0 replies; 7+ messages in thread
From: Dave Chinner @ 2018-01-31 23:52 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: xfs, Eric Sandeen
On Wed, Jan 31, 2018 at 02:23:24PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Now that reflink is no longer experimental, reject attempts to mount
> with DAX until that whole mess gets sorted out.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Make sense. Anyone trying to make this work needs to patch the
kernel, so having to patch out this check is no big deal.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] xfs: don't allow DAX on reflink filesystems
2018-01-31 22:23 [PATCH] xfs: don't allow DAX on reflink filesystems Darrick J. Wong
2018-01-31 23:11 ` Bill O'Donnell
2018-01-31 23:52 ` Dave Chinner
@ 2018-02-02 9:51 ` Christoph Hellwig
2018-02-02 17:47 ` Darrick J. Wong
2 siblings, 1 reply; 7+ messages in thread
From: Christoph Hellwig @ 2018-02-02 9:51 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: xfs, Dave Chinner, Eric Sandeen
On Wed, Jan 31, 2018 at 02:23:24PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Now that reflink is no longer experimental, reject attempts to mount
> with DAX until that whole mess gets sorted out.
Didn't I send exactly the same patch about a week ago?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] xfs: don't allow DAX on reflink filesystems
2018-02-02 9:51 ` Christoph Hellwig
@ 2018-02-02 17:47 ` Darrick J. Wong
2018-02-02 18:08 ` Christoph Hellwig
0 siblings, 1 reply; 7+ messages in thread
From: Darrick J. Wong @ 2018-02-02 17:47 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: xfs, Dave Chinner, Eric Sandeen
On Fri, Feb 02, 2018 at 01:51:31AM -0800, Christoph Hellwig wrote:
> On Wed, Jan 31, 2018 at 02:23:24PM -0800, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > Now that reflink is no longer experimental, reject attempts to mount
> > with DAX until that whole mess gets sorted out.
>
> Didn't I send exactly the same patch about a week ago?
I haven't received any such patch (but Oracle mail has been dropping and
delaying mail recently) and marc.info doesn't bring up anything relevant
for a search of 'DAX' and 'Hellwig'. :/
--D
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] xfs: don't allow DAX on reflink filesystems
2018-02-02 17:47 ` Darrick J. Wong
@ 2018-02-02 18:08 ` Christoph Hellwig
0 siblings, 0 replies; 7+ messages in thread
From: Christoph Hellwig @ 2018-02-02 18:08 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: Christoph Hellwig, xfs, Dave Chinner, Eric Sandeen
On Fri, Feb 02, 2018 at 09:47:33AM -0800, Darrick J. Wong wrote:
> I haven't received any such patch (but Oracle mail has been dropping and
> delaying mail recently) and marc.info doesn't bring up anything relevant
> for a search of 'DAX' and 'Hellwig'. :/
I've found my local commits from Jan 18, but it seems like they never
made it out, despite me remembering sending them. So it looks the issue
was in my side.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-02-02 18:08 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-31 22:23 [PATCH] xfs: don't allow DAX on reflink filesystems Darrick J. Wong
2018-01-31 23:11 ` Bill O'Donnell
2018-01-31 23:17 ` Bill O'Donnell
2018-01-31 23:52 ` Dave Chinner
2018-02-02 9:51 ` Christoph Hellwig
2018-02-02 17:47 ` Darrick J. Wong
2018-02-02 18:08 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).