From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Marco A Benatto <marco.antonio.780@gmail.com>
Cc: linux-xfs@vger.kernel.org, mbenatto@redhat.com
Subject: Re: [PATCH 1/2] xfs_mdrestore: Add -i option to built-in help
Date: Fri, 2 Feb 2018 12:22:49 -0800 [thread overview]
Message-ID: <20180202202249.GB4849@magnolia> (raw)
In-Reply-To: <1517598674-52297-1-git-send-email-marco.antonio.780@gmail.com>
On Fri, Feb 02, 2018 at 05:11:13PM -0200, Marco A Benatto wrote:
> Currently we are missing -i option from usage().
> This patch adds it to this biult-in help.
"built-in"
> Signed-off-by: Marco A Benatto <marco.antonio.780@gmail.com>
Otherwise looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> mdrestore/xfs_mdrestore.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mdrestore/xfs_mdrestore.c b/mdrestore/xfs_mdrestore.c
> index c49c13a..0bb4ac8 100644
> --- a/mdrestore/xfs_mdrestore.c
> +++ b/mdrestore/xfs_mdrestore.c
> @@ -194,7 +194,7 @@ perform_restore(
> static void
> usage(void)
> {
> - fprintf(stderr, "Usage: %s [-V] [-g] source target\n", progname);
> + fprintf(stderr, "Usage: %s [-V] [-g] [-i] source target\n", progname);
> exit(1);
> }
>
> --
> 1.8.3.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2018-02-02 20:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-02 19:11 [PATCH 1/2] xfs_mdrestore: Add -i option to built-in help Marco A Benatto
2018-02-02 19:11 ` [PATCH 2/2] xfs_mdrestore: Don't rewind source file stream Marco A Benatto
2018-02-02 20:27 ` Darrick J. Wong
2018-02-03 13:16 ` [PATCH] " Marco A Benatto
2018-02-03 13:18 ` Marco Benatto
2018-02-03 17:32 ` Darrick J. Wong
2018-02-05 11:50 ` Marco A Benatto
2018-02-05 16:47 ` Darrick J. Wong
2018-02-02 20:22 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180202202249.GB4849@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=marco.antonio.780@gmail.com \
--cc=mbenatto@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).