From: Dave Chinner <david@fromorbit.com>
To: Brian Foster <bfoster@redhat.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs_io: support a basic extent swap command
Date: Wed, 7 Feb 2018 12:34:41 +1100 [thread overview]
Message-ID: <20180207013441.fwxtfm7nbtsjwidp@destitution> (raw)
In-Reply-To: <20180206130247.61882-1-bfoster@redhat.com>
On Tue, Feb 06, 2018 at 08:02:47AM -0500, Brian Foster wrote:
> Extent swap is a low level mechanism exported by XFS to facilitate
> filesystem defragmentation. It is typically invoked by xfs_fsr under
> conditions that will atomically adjust inode extent state without
> loss of file data.
>
> xfs_fsr does not provide the necessary controls for low-level
> testing of the extent swap command, however. For example, xfs_fsr
> implements policies that dictate when to perform an extent swap and
> offers no control over the donor file characteristics.
Hmmmm. I'm confused - we already use xfs_fsr for low level testing
of swapext functionality with carefully constructed donor file
characteristics in xfs/227.
What am I missing here?
I don't see any problem with adding a specific command to run
more controlled swapext tests, i just want to make sure I understand
what xfs_fsr is not providing you with.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2018-02-07 1:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 13:02 [PATCH] xfs_io: support a basic extent swap command Brian Foster
2018-02-06 17:32 ` Darrick J. Wong
2018-02-06 18:49 ` Brian Foster
2018-02-07 1:34 ` Dave Chinner [this message]
2018-02-07 14:47 ` Brian Foster
2018-02-07 23:02 ` Dave Chinner
2018-02-07 23:23 ` Darrick J. Wong
2018-02-08 13:06 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180207013441.fwxtfm7nbtsjwidp@destitution \
--to=david@fromorbit.com \
--cc=bfoster@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox