linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Brian Foster <bfoster@redhat.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 3/4] xfs: rename agfl perag res type to rmapbt
Date: Wed, 7 Feb 2018 17:57:54 -0800	[thread overview]
Message-ID: <20180208015754.GE5433@magnolia> (raw)
In-Reply-To: <20180205174601.51574-4-bfoster@redhat.com>

On Mon, Feb 05, 2018 at 12:46:00PM -0500, Brian Foster wrote:
> The AGFL perag reservation type accounts all allocations that feed
> into (or are released from) the allocation group free list (agfl).
> The purpose of the reservation is to support worst case conditions
> for the reverse mapping btree (rmapbt). As such, the agfl
> reservation usage accounting only considers rmapbt usage when the
> in-core counters are initialized at mount time.
> 
> This implementation inconsistency leads to divergence of the in-core
> and on-disk usage accounting over time. In preparation to resolve
> this inconsistency and adjust the AGFL reservation into an rmapbt
> specific reservation, rename the AGFL reservation type and
> associated accounting fields to something more rmapbt-specific. Also
> fix up a couple tracepoints that incorrectly use the AGFL
> reservation type to pass the agfl state of the associated extent
> where the raw reservation type is expected.
> 
> Note that this patch does not change perag reservation behavior.
> 
> Signed-off-by: Brian Foster <bfoster@redhat.com>

Looks ok, though the tracepoint fix should probably be a standalone
patch.

Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

  reply	other threads:[~2018-02-08  1:57 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-05 17:45 [PATCH 0/4] xfs: rmapbt block and perag reservation fixups Brian Foster
2018-02-05 17:45 ` [PATCH 1/4] xfs: shutdown if block allocation overruns tx reservation Brian Foster
2018-02-08  1:42   ` Darrick J. Wong
2018-02-05 17:45 ` [PATCH 2/4] xfs: account format bouncing into rmapbt swapext " Brian Foster
2018-02-08  1:56   ` Darrick J. Wong
2018-02-08 13:12     ` Brian Foster
2018-02-05 17:46 ` [PATCH 3/4] xfs: rename agfl perag res type to rmapbt Brian Foster
2018-02-08  1:57   ` Darrick J. Wong [this message]
2018-02-05 17:46 ` [PATCH 4/4] xfs: account only rmapbt-used blocks against rmapbt perag res Brian Foster
2018-02-07  0:03   ` Darrick J. Wong
2018-02-07 14:49     ` Brian Foster
2018-02-08  2:20       ` Darrick J. Wong
2018-02-08 13:19         ` Brian Foster
2018-02-08 22:49           ` Dave Chinner
2018-02-09 13:37             ` Brian Foster
2018-02-06 13:10 ` [PATCH] tests/xfs: rmapbt swapext block reservation overrun test Brian Foster
2018-02-06 17:30   ` Darrick J. Wong
2018-02-06 18:50     ` Brian Foster
2018-02-07  4:07     ` Eryu Guan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180208015754.GE5433@magnolia \
    --to=darrick.wong@oracle.com \
    --cc=bfoster@redhat.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).