From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
Todd Gill <tgill@redhat.com>,
linux-xfs@vger.kernel.org
Subject: Re: XFS over device mapper dm-thin device
Date: Fri, 9 Feb 2018 08:11:44 +1100 [thread overview]
Message-ID: <20180208211144.GD20266@dastard> (raw)
In-Reply-To: <744222fe-7774-5086-20b7-48b8326cad99@sandeen.net>
On Thu, Feb 08, 2018 at 08:31:21AM -0600, Eric Sandeen wrote:
>
>
> On 2/8/18 2:25 AM, Dave Chinner wrote:
> > On Wed, Feb 07, 2018 at 09:53:40PM -0800, Darrick J. Wong wrote:
> >> On Wed, Feb 07, 2018 at 08:35:12PM -0600, Eric Sandeen wrote:
> >>>
> >>>
> >>> On 2/6/18 12:11 AM, Dave Chinner wrote:
> >>>> On Mon, Feb 05, 2018 at 04:37:22PM -0600, Eric Sandeen wrote:
> >>>>>
> >>>>>
> >>>>> On 2/5/18 4:36 PM, Dave Chinner wrote:
> >>>>>>> In retrospect I think we (I) should have left the "metadata" uuid as
> >>>>>>> the one to match the log, not the user-facing one.
> >>>>>> I suspect we can just change the log recovery code to accept either
> >>>>>> sb_uuid or sb_metauuid if the metauuid feature bit is set and
> >>>>>> change xfs_db to not rewrite the log when metauuid is used....
> >>>>>>
> >>>>>> Cheers,
> >>>>>
> >>>>> That was my first thought, but then newer userspace UUID changes
> >>>>> won't be mountable on older kernels. I don't think we can just
> >>>>> change it w/o some thought re: compatibility...
> >>>>
> >>>> So maybe we should use a log incompat bit and provide an alternative
> >>>> command for the old way of changing the UUID in the log?
> >>>
> >>> Sure, if we're happy burning an incompat bit for this, sounds good.
> >>
> >> Or a log incompat bit?
> >
> > That's what I suggested :P
>
> And that's what I /meant/, sorry for the lack of specificity ;)
So we are all happy to burn a log incompat bit for this?
/me wonders how many one liners we can string this out into :)
-Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2018-02-08 21:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-02 21:45 XFS over device mapper dm-thin device Todd Gill
2018-02-02 22:35 ` Dave Chinner
2018-02-02 23:36 ` Eric Sandeen
2018-02-05 22:36 ` Dave Chinner
2018-02-05 22:37 ` Eric Sandeen
2018-02-06 6:11 ` Dave Chinner
2018-02-08 2:35 ` Eric Sandeen
2018-02-08 5:53 ` Darrick J. Wong
2018-02-08 8:25 ` Dave Chinner
2018-02-08 14:31 ` Eric Sandeen
2018-02-08 21:11 ` Dave Chinner [this message]
2018-02-09 1:39 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180208211144.GD20266@dastard \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
--cc=tgill@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).