From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Carlos Maiolino <cmaiolino@redhat.com>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] Cleanup old XFS_BTREE_* traces
Date: Tue, 13 Feb 2018 08:21:06 +1100 [thread overview]
Message-ID: <20180212212106.GD6778@dastard> (raw)
In-Reply-To: <20180212182948.GB5217@magnolia>
On Mon, Feb 12, 2018 at 10:29:48AM -0800, Darrick J. Wong wrote:
> On Mon, Feb 12, 2018 at 02:00:05PM +0100, Carlos Maiolino wrote:
> > Remove unused legacy btree traces from IRIX era.
> >
> > Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
> > ---
> >
> > Talking to Dave about it, he mentioned XFS_BTREE_TRACE_CURSOR might be worth to
> > turn into a proper ftrace trace point, so I didn't touch _CURSOR traces in this
> > patchset, and a proper conversion will be sent later, unless it's not worth at
> > all, and I should send a V2 also removing TRACE_CURSOR.
>
> TBH I wonder the opposite -- why not turn all of these into tracepoints?
TBH, we haven't used them in at least 15 years. What value do they
provide apart from making the traces even noisier (and potentially
more lossy) than they already are?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2018-02-12 21:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-12 13:00 [PATCH] Cleanup old XFS_BTREE_* traces Carlos Maiolino
2018-02-12 18:29 ` Darrick J. Wong
2018-02-12 21:21 ` Dave Chinner [this message]
2018-02-13 23:17 ` Darrick J. Wong
2018-02-13 23:58 ` Dave Chinner
2018-02-14 13:52 ` Carlos Maiolino
2018-02-14 17:28 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180212212106.GD6778@dastard \
--to=david@fromorbit.com \
--cc=cmaiolino@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).